fs: add signal option to fs.stat()

[mertcanaltin]

add signal option to fs.stat() for #57751

[codecov]

Codecov Report

Attention: Patch coverage is 95.12195% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.24%. Comparing base (964e41c) to head (99ec837).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/fs.js	95.12%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             main   #57775    +/-   ##
========================================
  Coverage   90.23%   90.24%            
========================================
  Files         630      630            
  Lines      185518   185707   +189     
  Branches    36369    36412    +43     
========================================
+ Hits       167401   167587   +186     
+ Misses      11005    10999     -6     
- Partials     7112     7121     +9     

Files with missing lines	Coverage Δ
lib/fs.js	98.22% <95.12%> (-0.05%)	⬇️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[LiviaMedeiros]

The commit message after subsystem should start with imperative verb and probably be more specific, maybe something like fs: add signal option to fs.stat()?

[LiviaMedeiros]

Non-blocking concern, since oncomplete is our happy path here: this code paired with makeStatsCallback essentially wraps the callback twice. Maybe we can somehow avoid this, even at the cost of making abort paths slower and uglier.

[mertcanaltin]

I wonder if you think this method is good?

To avoid wrapping the callback twice during the happy path, I do not wrap the callback at the beginning, I wrap it with a one-time makeStatsCallback in oncomplete after the abort check. When the abort condition occurs, I call the normal callback directly.

[LiviaMedeiros]

This is not perfect (we still validate callback twice and wrap twice inside the happy path), but I don't see perfect solution without rewriting all functions that use makeStatsCallback in the same way.
A good compromise for now would be adding a TODO comment here and optimizing it later.

[mertcanaltin]

Can I leave it as it is now and add todo?

[mertcanaltin]

I try added to this line 28bc2c3

[mertcanaltin]

The commit message after subsystem should start with imperative verb and probably be more specific, maybe something like fs: add signal option to fs.stat()?

thank you very much, I will be more careful with this, sometimes I make the wrong sentence 🙏

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66196/

[LiviaMedeiros]

Doesn't necessarily have to be in scope of this PR, but i think we'll also need signal option for Sync and Promises API of this function, and also for the lstat version; ideally within same semver-minor release so there's no discrepancy between these functions.

[targos]

Test is writing a temporary file in the cwd. It should use common API instead

[jasnell]

@mertcanaltin ... can you please remove the merge commit from this and use rebase instead to catch it up?

[mertcanaltin]

@mertcanaltin ... can you please remove the merge commit from this and use rebase instead to catch it up?

thank you I used rebase

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66241/