doc: process.execve is only unavailable for Windows #57726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
ljharb
reviewed
Apr 2, 2025
execve() call is available on Android as well. When process.execve was first added, it seems like no one checked if that is actually available on Android as well and works out of the box as __POSIX__ is defined on Android. process.execve call seems to behave just as fine as on Linux environment in my testing, so just make the docs specify it.
thunder-coding
force-pushed
the
execve-android-doc
branch
from
7a188a2 to
8e6dd82
Compare
|
I guess Android is POSIX, it's listed as "Mostly POSIX-compliant" on https://en.wikipedia.org/wiki/POSIX#POSIX-oriented_operating_systems. Given that it seems to be possible to get POSIX for Windows, I wonder if we should keep mentioning POSIX 🤔 |
|
Also, I don't know if IBMI is POSIX but it doesn't support execve: https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi74-ppc64/1883/#showFailuresLink @nodejs/platform-ibmi |
|
@targos It seems the syscall exists but we get a EPERM error somehow. |
aduh95
added
the
author ready
|
Hi @targos I'm currently investigating why we are getting back EPERM error on IBM i for some reason, execve does exist and I tested it using a simple C program. |
marco-ippolito
approved these changes
Apr 3, 2025
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 78e2f99 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
execve() call is available on Android as well. When process.execve was first added, it seems like no one checked if that is actually available on Android as well and works out of the box as
__POSIX__is defined on Android. process.execve call seems to behave just as fine as on Linux environment in my testing, so just make the docs specify it.