src: fixup fs SyncCall to propagate errors correctly #57711
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Propagate errors correctly in the SyncCall utility. Previously the test case would trigger a crash.
jasnell
force-pushed
the
jasnell/fs-sync-crash-fix
branch
from
a76b761 to
75ebfdd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57711 +/- ##
=======================================
Coverage 90.22% 90.23%
=======================================
Files 630 630
Lines 185073 185092 +19
Branches 36222 36231 +9
=======================================
+ Hits 166990 167018 +28
+ Misses 11044 11037 -7
+ Partials 7039 7037 -2
🚀 New features to boost your workflow:
|
aduh95
approved these changes
Apr 1, 2025
Co-authored-by: Antoine du Hamel <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
the
author ready
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
Apr 3, 2025
jasnell
added a commit
that referenced
this pull request
Apr 3, 2025
Propagate errors correctly in the SyncCall utility. Previously the test case would trigger a crash. PR-URL: #57711 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
|
Landed in 538c813 |
JonasBa
pushed a commit
to JonasBa/node
that referenced
this pull request
Apr 11, 2025
Propagate errors correctly in the SyncCall utility. Previously the test case would trigger a crash. PR-URL: nodejs#57711 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
May 1, 2025
Propagate errors correctly in the SyncCall utility. Previously the test case would trigger a crash. PR-URL: #57711 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
May 2, 2025
Propagate errors correctly in the SyncCall utility. Previously the test case would trigger a crash. PR-URL: #57711 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95
added
the
backport-requested-v22.x
|
Test is crashing on v22.x-staging with this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagate errors correctly in the SyncCall utility.
Previously the test case would trigger a crash.