Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2025-04-01, Version 23.11.0 (Current) #57694

Merged
merged 93 commits into from
Apr 1, 2025
Merged

2025-04-01, Version 23.11.0 (Current) #57694

merged 93 commits into from
Apr 1, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 30, 2025

Notable changes

  • [64b086740a] - (SEMVER-MINOR) assert: implement partial error comparison (Ruben Bridgewater) #57370
  • [053cef70e0] - (SEMVER-MINOR) crypto: add optional callback to crypto.diffieHellman (Filip Skokan) #57274
  • [f8aff90235] - (SEMVER-MINOR) process: add execve (Paolo Insogna) #56496
  • [4b04c92d7d] - (SEMVER-MINOR) sqlite: add StatementSync.prototype.columns() (Colin Ihrig) #57490
  • [1b8d1d3a3a] - (SEMVER-MINOR) util: expose diff function used by the assertion errors (Giovanni Bucci) #57462
Commits
  • [7b72396c8b] - assert: improve partialDeepStrictEqual performance (Ruben Bridgewater) #57509
  • [64b086740a] - (SEMVER-MINOR) assert: implement partial error comparison (Ruben Bridgewater) #57370
  • [f694d7de0e] - (SEMVER-MINOR) assert: improve partialDeepStrictEqual (Ruben Bridgewater) #57370
  • [80d9d5653f] - (SEMVER-MINOR) assert,util: improve performance (Ruben Bridgewater) #57370
  • [d52a71f832] - (SEMVER-MINOR) benchmark: adjust assert runtimes (Ruben Bridgewater) #57370
  • [7592cf4cd7] - (SEMVER-MINOR) benchmark: skip running some assert benchmarks by default (Ruben Bridgewater) #57370
  • [e4cc54a746] - (SEMVER-MINOR) benchmark: add assert partialDeepStrictEqual benchmark (Ruben Bridgewater) #57370
  • [de48407011] - build: fix update-wpt workflow (Jonas) #57468
  • [52cd0954f9] - cli: clarify --cpu-prof-name allowed values (Eugenio Ceschia) #57433
  • [cc42ee8fc7] - crypto: ensure expected JWK alg in SubtleCrypto.importKey RSA imports (Filip Skokan) #57450
  • [053cef70e0] - (SEMVER-MINOR) crypto: add optional callback to crypto.diffieHellman (Filip Skokan) #57274
  • [1f08864fd7] - debugger: fix behavior of plain object exec in debugger repl (Dario Piotrowicz) #57498
  • [162b2828eb] - deps: update undici to 6.21.2 (Matteo Collina) #57442
  • [43bea6bb80] - deps: V8: cherry-pick c172ffc5bf54 (Choongwoo Han) #57437
  • [99f93afb9d] - deps: update ada to v3.2.1 (Yagiz Nizipli) #57429
  • [30e5658f12] - deps: update googletest to 0bdccf4 (Node.js GitHub Bot) #57380
  • [573467c070] - deps: update acorn to 8.14.1 (Node.js GitHub Bot) #57382
  • [affeaac0c7] - doc: add gurgunday as triager (Gürgün Dayıoğlu) #57594
  • [4ed1a098f5] - doc: clarify behaviour of node-api adjust function (Michael Dawson) #57463
  • [921041b284] - doc: remove Corepack documentation (Antoine du Hamel) #57635
  • [99dbd8b391] - doc: remove mention of --require not supporting ES modules (Huáng Jùnliàng) #57620
  • [8c76b2949e] - doc: mention reports should align with Node.js CoC (Rafael Gonzaga) #57607
  • [ee1c78a7a3] - doc: add section stating that very stale PRs should be closed (Dario Piotrowicz) #57541
  • [595e9e5ad6] - doc: add bjohansebas as triager (Sebastian Beltran) #57564
  • [3742d2a198] - doc: update support channels (Claudio W.) #57538
  • [717c44dead] - doc: make stability labels more consistent (Antoine du Hamel) #57516
  • [b4576a6f57] - doc: remove cryptoStream API reference (Jonas) #57579
  • [2c4f894036] - doc: module resolution pseudocode corrections (Marcel Laverdet) #57080
  • [c45894f90c] - doc: add history entry for DEP0190 in child_process.md (Antoine du Hamel) #57544
  • [c21068b696] - doc: remove deprecated pattern in child_process.md (Antoine du Hamel) #57568
  • [87e0dda352] - doc: mark multiple experimental APIS as stable (James M Snell) #57510
  • [d637763e4e] - doc: remove mertcanaltin from Triagers (Mert Can Altin) #57531
  • [ee6025495d] - doc: recommend watching the collaborators repo in the onboarding doc (Darshan Sen) #57527
  • [706b64638b] - doc: remove mention of visa fees from onboarding doc (Darshan Sen) #57526
  • [176d951bd0] - doc: deprecate passing args to spawn and execFile (Antoine du Hamel) #57389
  • [5c05ba119b] - doc: remove some inconsistencies in deprecations.md (Antoine du Hamel) #57512
  • [9d5be4bb8c] - doc: run license-builder (github-actions[bot]) #57511
  • [273607edb4] - doc: add new writing-docs contributing md (Dario Piotrowicz) #57502
  • [e28c723f24] - doc: add node.js streams references to Web Streams doc (Dario Piotrowicz) #57393
  • [47296492ba] - doc: replace NOTEs that do not render properly (Colin Ihrig) #57484
  • [db9c37f792] - doc: prefer to sign commits under nodejs repository (Rafael Gonzaga) #57311
  • [e5e3987ae7] - doc: fixed the incorrect splitting of multiple words (letianpailove) #57454
  • [91a824e43b] - doc: add review guidelines for collaborator nominations (Antoine du Hamel) #57449
  • [2a5fcb2172] - doc: fix typo in url.md (Allon Murienik) #57467
  • [17ccf9282f] - doc: add history info for --use-system-ca (Darshan Sen) #57432
  • [9adaaeb965] - doc: remove typo YAML snippet from tls.getCACertificates doc (Darshan Sen) #57459
  • [ee4e855f8e] - doc: fix typo in sqlite.md (Tobias Nießen) #57473
  • [8cb3441443] - doc: explicit mention arbitrary code execution as a vuln (Rafael Gonzaga) #57426
  • [27f183ad03] - doc: update maintaining-openssl.md for openssl (Richard Lau) #57413
  • [ca67145d60] - doc: add missing deprecated badges in fs.md (Yukihiro Hasegawa) #57384
  • [3687390510] - doc: fix small typo in process.md (Felix Rieseberg) #57333
  • [097d9926e3] - doc: add note about sync nodejs-private branches (Rafael Gonzaga) #57404
  • [5006627969] - fs: apply exclude function to root path (Rich Trott) #57420
  • [0583c3db92] - http: coerce content-length to number (Marco Ippolito) #57458
  • [2a580b9332] - lib: add warning when binding inspector to public IP (Demian Parkhomenko) #55736
  • [fda56b9837] - lib: limit split function calls to prevent excessive array length (Gürgün Dayıoğlu) #57501
  • [d5a26f6525] - lib: make getCallSites sourceMap option truly optional (James M Snell) #57388
  • [00a5b18043] - meta: add some clarification to the nomination process (James M Snell) #57503
  • [d0c96c463c] - meta: remove collaborator self-nomination (Rich Trott) #57537
  • [a9a93f31ee] - meta: edit collaborator nomination process (Antoine du Hamel) #57483
  • [0ca362f5f2] - meta: move ovflowd to emeritus (Claudio W.) #57443
  • [f8aff90235] - (SEMVER-MINOR) process: add execve (Paolo Insogna) #56496
  • [e8d4a31d4b] - sqlite: add support for unknown named parameters (Colin Ihrig) #57552
  • [5652da642d] - sqlite: add DatabaseSync.prototype.isOpen (Colin Ihrig) #57522
  • [5c976f16cd] - sqlite: add DatabaseSync.prototype[Symbol.dispose]() (Colin Ihrig) #57506
  • [4b04c92d7d] - (SEMVER-MINOR) sqlite: add StatementSync.prototype.columns() (Colin Ihrig) #57490
  • [7f5e31645c] - src: ensure primordials are initialized exactly once (Chengzhong Wu) #57519
  • [9611980f58] - src: improve error handling in multiple files (James M Snell) #57507
  • [3ddc5cd875] - src: cache urlpattern properties (JonasBa) #57465
  • [b9d9ee4da2] - src: make minor cleanups in encoding_binding.cc (James M Snell) #57448
  • [f8acf2dd2a] - src: make minor cleanups in compile_cache.cc (James M Snell) #57448
  • [6ee15c6509] - src: define urlpattern components using a macro (JonasBa) #57452
  • [4ab3c1690a] - src: cleanup crypto more (James M Snell) #57323
  • [5be80b1748] - src: refine ncrypto more (James M Snell) #57300
  • [6a13319a6e] - src: cleanup aliased_buffer.h (Mohammed Keyvanzadeh) #57395
  • [3cff7f80bb] - src: suggest --use-system-ca when a certificate error occurs (Aditi) #57362
  • [3d372ad9f3] - test: update WPT for urlpattern to 6ceca69d26 (Node.js GitHub Bot) #57486
  • [481ea665af] - test: add more number cases for buffer.indexOf (Meghan Denny) #57200
  • [27b01ed4e7] - test: update parallel/test-tls-dhe for OpenSSL 3.5 (Richard Lau) #57477
  • [8f7debcf41] - timers: optimize timer functions with improved argument handling (Gürgün Dayıoğlu) #57072
  • [d4abd9d3fb] - timers: remove unnecessary allocation of _onTimeout (Gürgün Dayıoğlu) #57497
  • [f8f81c8ba2] - timers: remove unused parameter from insertGuarded (Gürgün Dayıoğlu) #57251
  • [c4fdb27b51] - tls: remove unnecessary type check on normalize (Yagiz Nizipli) #57336
  • [ad5dcc5798] - tools: fix WPT update cron string (Antoine du Hamel) #57665
  • [7faa482588] - tools: remove stalled label on unstalled issues and PRs (Rich Trott) #57630
  • [e3bb26da2b] - tools: update sccache to support GH cache changes (Michaël Zasso) #57573
  • [f0c9f505d9] - tools: bump @babel/helpers from 7.26.9 to 7.26.10 in /tools/eslint (dependabot[bot]) #57444
  • [a40ff1f646] - url: fix constructor error message for URLPattern (jakecastelli) #57482
  • [f36bee4b89] - util: avoid run debug when enabled is false (fengmk2) #57494
  • [1b8d1d3a3a] - (SEMVER-MINOR) util: expose diff function used by the assertion errors (Giovanni Bucci) #57462
  • [1f7b08a317] - win,test: disable test case failing with ClangCL (Stefan Stojanovic) #57397

StefanStojanovic and others added 30 commits March 18, 2025 11:14
PR-URL: #57397
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This significantly improves the assert.partialDeepStrictEqual
implementation by reusing the already existing algorithm.
It is significantly faster and handles edge cases like symbols
identical as the deepStrictEqual algorithm. This is crucial to
remove the experimental status from the implementation.

PR-URL: #57370
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
The current settings deactivate the extraProps handling, due to
the current implementation failing on these cases.

PR-URL: #57370
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
These benchmarks are not frequently needed and just slow down the
default benchmark suite. They are kept for users who want to run
them but deactivated by default.

PR-URL: #57370
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Each file should have a reasonable runtime while having a good
accuracy. This adjust those up and down to have minimal runtimes
with a good accuracy.

PR-URL: #57370
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
This improves the performance for array comparison by making the
sparse array detection simpler. On top of that it adds a fast path
for sets and maps that only contain objects as key.

PR-URL: #57370
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
assert.partialDeepStrictEqual now also handled error properties as
expected. On top of that, the main implementation also handles
non-string `name` and `message` properties and the comparison is a
tad faster by removing duplicated comparison steps.

As a drive-by fix this also cleans up some code by abstracting code
and renaming variables for clarity.

PR-URL: #57370
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
PR-URL: #57404
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #57251
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #57333
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #57336
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #57384
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
- Mark `AliasedBufferBase` as `final` as nothing derives from it.
- Simplify scalar check with `std::is_scalar_v`.
- Remove redundant `const`-qualifiers from function declaration
parameters.
- Add `const`-qualifiers to function definition parameters where
appropriate.
- Remove redundant `inline` specifiers from functions that are
templates or has template parents, and from functions that are entirely
declared inside class definitions.
- Remove redundant template arguments.
- Remove redundant qualified name.
- Fix typo and improve grammar.

PR-URL: #57395
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
An eventual goal for ncrypto is to completely abstract away
details of working directly with openssl in order to make it
easier to work with multiple different openssl/boringssl versions.
As part of that we want to move away from direct reliance on
specific openssl APIs in the runtime and instead go through
the ncrypto abstractions. Not only does this help other
runtimes trying to be compatible with Node.js, but it helps
Node.js also by reducing the complexity of the crypto code
in Node.js itself.

PR-URL: #57300
Reviewed-By: Yagiz Nizipli <[email protected]>
Update the instructions for maintaining OpenSSL in the Node.js source
tree to reflect switching back from the quictls fork of OpenSSL back
to official OpenSSL.

PR-URL: #57413
Refs: #57301
Refs: #57142
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #57443
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #57382
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #57380
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
When calling the `util.getCallSites(...)` API, if the `options`
argument is omitted, then the `options.sourceMap` option is defaulted
to false. However, if any empty `options` is passed, it would throw
an error is `sourceMap` was not explicitly given. This relaxes that
so that `sourceMap` can be left unspecified.

For instance, before this commit, `getCallSites({})` would throw an
error.

Also, add more test coverage of this.

PR-URL: #57388
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
* Use ncrypto APIs where appropriate
* Remove obsolete no-longer used functions
* Improve error handling a bit
* move secure heap handling to ncrypto
  To simplify handling of boringssl/openssl, move secure
  heap impl to ncrypto. Overall the reduces the complexity
  of the code in crypto_util by eliminating additional
  ifdef branches.
* simplify CryptoErrorStore::ToException a bit
* simplify error handling in crypto_common
* move curve utility methods to ncrypto
* verify that released DataPointers aren't on secure heap
  The ByteSource does not currently know how to free a DataPointer
  allocated on the secure heap, so just verify.
  DataPointers on the secure heap are not something that users can
  allocate on their own. Their use is rare. Eventually ByteSource
  is going to be refactored around ncrypto APIs so these additional
  checks should be temporary.
* simplify some ifdefs that are covered by ncrypto
* cleanup some obsolete includes in crypto_util

PR-URL: #57323
Reviewed-By: Yagiz Nizipli <[email protected]>
This request came from Github Open Source Secure and
it's always welcome to clarify the policy

PR-URL: #57426
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
PR-URL: #57429
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #57473
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Edy Silva <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Noticed it while going through
https://github.com/nodejs/node/pull/57107/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7deR2399,
so thought of removing it.

Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #57459
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
These are the PRs for --use-system-ca:
- initial implementation of the option with just macOS support
  #56599 landed in v23.8.0.
- Windows support #56833
  landed in v23.8.0
- non-Windows and non-macOS support
  #57009 landed in v23.9.0

This change documents the history info.

Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #57432
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
"objg" -> "obj" in `URLPattern` constructor documentation.

Fixes: #57464
PR-URL: #57467
Co-authored-by: Lawlight <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #57274
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Bumps [@babel/helpers](https://github.com/babel/babel/tree/HEAD/packages/babel-helpers) from 7.26.9 to 7.26.10.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.26.10/packages/babel-helpers)

---
updated-dependencies:
- dependency-name: "@babel/helpers"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
PR-URL: #57444
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #57468
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
The comment says every week, but the actual string defines every day.
Let's set it to one week, as it is quite noisy at the moment.

PR-URL: #57665
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
nodejs-github-bot added a commit that referenced this pull request Mar 30, 2025
Notable changes:

assert:
  * (SEMVER-MINOR) implement partial error comparison (Ruben Bridgewater) #57370
  * (SEMVER-MINOR) improve partialDeepStrictEqual (Ruben Bridgewater) #57370
assert,util:
  * (SEMVER-MINOR) improve performance (Ruben Bridgewater) #57370
benchmark:
  * (SEMVER-MINOR) adjust assert runtimes (Ruben Bridgewater) #57370
  * (SEMVER-MINOR) skip running some assert benchmarks by default (Ruben Bridgewater) #57370
  * (SEMVER-MINOR) add assert partialDeepStrictEqual benchmark (Ruben Bridgewater) #57370
crypto:
  * (SEMVER-MINOR) add optional callback to crypto.diffieHellman (Filip Skokan) #57274
process:
  * (SEMVER-MINOR) add execve (Paolo Insogna) #56496
sqlite:
  * (SEMVER-MINOR) add StatementSync.prototype.columns() (Colin Ihrig) #57490
util:
  * (SEMVER-MINOR) expose diff function used by the assertion errors (Giovanni Bucci) #57462

PR-URL: #57694
@github-actions github-actions bot added release Issues and PRs related to Node.js releases. v23.x v23.x Issues that can be reproduced on v23.x or PRs targeting the v23.x-staging branch. labels Mar 30, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/gyp
  • @nodejs/performance
  • @nodejs/security-wg
  • @nodejs/tsc

@aduh95 aduh95 force-pushed the v23.11.0-proposal branch from 4c2045d to bd770fd Compare March 30, 2025 21:29
aduh95 added a commit that referenced this pull request Mar 30, 2025
Notable changes:

assert:
  * (SEMVER-MINOR) implement partial error comparison (Ruben Bridgewater) #57370
crypto:
  * (SEMVER-MINOR) add optional callback to `crypto.diffieHellman` (Filip Skokan) #57274
process:
  * (SEMVER-MINOR) add `execve` (Paolo Insogna) #56496
sqlite:
  * (SEMVER-MINOR) add `StatementSync.prototype.columns()` (Colin Ihrig) #57490
util:
  * (SEMVER-MINOR) expose diff function used by the assertion errors (Giovanni Bucci) #57462

PR-URL: #57694
Co-authored-by: Antoine du Hamel <[email protected]>
@aduh95 aduh95 marked this pull request as ready for review March 30, 2025 21:30
@nodejs-github-bot

This comment was marked as outdated.

Copy link

codecov bot commented Mar 30, 2025

Codecov Report

Attention: Patch coverage is 87.53541% with 132 lines in your changes missing coverage. Please review.

Project coverage is 90.25%. Comparing base (39e295d) to head (9ad070e).
Report is 95 commits behind head on v23.x.

Files with missing lines Patch % Lines
src/crypto/crypto_cipher.cc 55.93% 13 Missing and 13 partials ⚠️
src/node_process_methods.cc 67.24% 16 Missing and 3 partials ⚠️
src/crypto/crypto_util.cc 63.63% 8 Missing and 8 partials ⚠️
src/node_sqlite.cc 80.72% 5 Missing and 11 partials ⚠️
src/node_builtins.cc 59.09% 0 Missing and 9 partials ⚠️
src/crypto/crypto_dh.cc 73.68% 0 Missing and 5 partials ⚠️
src/crypto/crypto_x509.cc 63.63% 0 Missing and 4 partials ⚠️
lib/internal/assert/myers_diff.js 85.71% 3 Missing ⚠️
lib/internal/fs/glob.js 88.00% 3 Missing ⚠️
lib/internal/util/comparisons.js 99.11% 2 Missing and 1 partial ⚠️
... and 14 more
Additional details and impacted files
@@            Coverage Diff             @@
##            v23.x   #57694      +/-   ##
==========================================
- Coverage   90.25%   90.25%   -0.01%     
==========================================
  Files         630      631       +1     
  Lines      185130   185082      -48     
  Branches    36252    36247       -5     
==========================================
- Hits       167097   167051      -46     
- Misses      10981    11004      +23     
+ Partials     7052     7027      -25     
Files with missing lines Coverage Δ
lib/_http_outgoing.js 95.24% <100.00%> (ø)
lib/_tls_wrap.js 93.38% <100.00%> (ø)
lib/assert.js 99.52% <100.00%> (+0.47%) ⬆️
lib/inspector.js 96.91% <100.00%> (+0.18%) ⬆️
lib/internal/blob.js 99.80% <100.00%> (ø)
lib/internal/bootstrap/node.js 99.57% <100.00%> (+<0.01%) ⬆️
lib/internal/crypto/hashnames.js 100.00% <100.00%> (+2.38%) ⬆️
lib/internal/crypto/rsa.js 92.14% <100.00%> (+0.08%) ⬆️
lib/internal/debugger/inspect.js 93.98% <100.00%> (ø)
lib/internal/debugger/inspect_repl.js 91.76% <100.00%> (+0.05%) ⬆️
... and 61 more

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@TheNorthMemory
Copy link

hopes the one #57575 in, because the problem was here on v23.7.0/23.8.0/23.9.0/23.10.0.

closes #57553
closes #57572
closes #57558

PR-URL: #57575
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@aduh95 aduh95 force-pushed the v23.11.0-proposal branch from bd770fd to 32c6759 Compare April 1, 2025 09:24
aduh95 added a commit that referenced this pull request Apr 1, 2025
Notable changes:

assert:
  * (SEMVER-MINOR) implement partial error comparison (Ruben Bridgewater) #57370
crypto:
  * (SEMVER-MINOR) add optional callback to `crypto.diffieHellman` (Filip Skokan) #57274
process:
  * (SEMVER-MINOR) add `execve` (Paolo Insogna) #56496
sqlite:
  * (SEMVER-MINOR) add `StatementSync.prototype.columns()` (Colin Ihrig) #57490
util:
  * (SEMVER-MINOR) expose diff function used by the assertion errors (Giovanni Bucci) #57462

PR-URL: #57694
Notable changes:

assert:
  * (SEMVER-MINOR) implement partial error comparison (Ruben Bridgewater) #57370
crypto:
  * (SEMVER-MINOR) add optional callback to `crypto.diffieHellman` (Filip Skokan) #57274
process:
  * (SEMVER-MINOR) add `execve` (Paolo Insogna) #56496
sqlite:
  * (SEMVER-MINOR) add `StatementSync.prototype.columns()` (Colin Ihrig) #57490
util:
  * (SEMVER-MINOR) expose diff function used by the assertion errors (Giovanni Bucci) #57462

PR-URL: #57694
@aduh95 aduh95 force-pushed the v23.11.0-proposal branch from 32c6759 to 9ad070e Compare April 1, 2025 09:25
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 1, 2025

@aduh95 aduh95 merged commit 9ad070e into v23.x Apr 1, 2025
48 of 51 checks passed
aduh95 added a commit that referenced this pull request Apr 1, 2025
Notable changes:

assert:
  * (SEMVER-MINOR) implement partial error comparison (Ruben Bridgewater) #57370
crypto:
  * (SEMVER-MINOR) add optional callback to `crypto.diffieHellman` (Filip Skokan) #57274
process:
  * (SEMVER-MINOR) add `execve` (Paolo Insogna) #56496
sqlite:
  * (SEMVER-MINOR) add `StatementSync.prototype.columns()` (Colin Ihrig) #57490
util:
  * (SEMVER-MINOR) expose diff function used by the assertion errors (Giovanni Bucci) #57462

PR-URL: #57694
@aduh95 aduh95 deleted the v23.11.0-proposal branch April 1, 2025 14:24
aduh95 added a commit that referenced this pull request Apr 1, 2025
aduh95 added a commit to aduh95/nodejs.org that referenced this pull request Apr 1, 2025
github-merge-queue bot pushed a commit to nodejs/nodejs.org that referenced this pull request Apr 1, 2025
@aduh95 aduh95 changed the title 2025-03-31, Version 23.11.0 (Current) 2025-04-01, Version 23.11.0 (Current) Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues and PRs related to Node.js releases. v23.x v23.x Issues that can be reproduced on v23.x or PRs targeting the v23.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.