quic: fix debug log #57689
Merged
quic: fix debug log #57689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakecastelli
added
the
fast-track
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
added
needs-ci
jakecastelli
force-pushed
the
fix-quic-debug-typos
branch
from
c7737b2 to
5eda7aa
Compare
anonrig
approved these changes
Mar 30, 2025
lpinca
approved these changes
Mar 30, 2025
bjohansebas
approved these changes
Mar 30, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57689 +/- ##
==========================================
- Coverage 90.23% 90.22% -0.01%
==========================================
Files 630 630
Lines 185055 185055
Branches 36221 36214 -7
==========================================
- Hits 166984 166973 -11
- Misses 11043 11046 +3
- Partials 7028 7036 +8 🚀 New features to boost your workflow:
|
cjihrig
approved these changes
Mar 30, 2025
|
I'm not sure this can currently be fast tracked because it requires a full CI run and the CI is locked down. |
|
oh yes, thanks for the reminder, forgot about the CI situation when I created the PR |
jakecastelli
removed
the
fast-track
benjamingr
approved these changes
Mar 31, 2025
MoLow
approved these changes
Apr 1, 2025
github-actions
bot
removed
the
request-ci
Well, that and quic is no longer built by default in CI ;-) |
jakecastelli
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in 10cff7b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.