src,lib,test: unflag --experimental-webstorage by default

[danielmbrasil]

Resolves #57658

[nodejs-github-bot]

Review requested:

• @nodejs/config

[mcollina]

To fix the failing test, I would change the error being throw in lib/internal/webstorage.js in a warning, and have localStorage be undefined in that case.

@cjihrig wdyt?

[cjihrig]

I would be OK with that behavior. However, the global checking logic in test/common/index.js would probably need to be updated. Otherwise, the new warning will probably be printed for every test that doesn't use localStorage.

[danielmbrasil]

I just pushed the suggested changes, and the tests are now passing. @cjihrig, could you please review whether the changes in test/common/index.js make sense?

[cjihrig]

Without running the code, it doesn't look correct to me:

globalThis[val] === undefined

By the time we find out that the value is undefined, the warning will have already been emitted, right?

[danielmbrasil]

By the time we find out that the value is undefined, the warning will have already been emitted, right?

Yeah, that's right. I'll take a look on how to avoid the warning to be emitted in those cases.

[danielmbrasil]

@cjihrig Could you take a look now and see if this is closer to what you were expecting? I added a new check to test/common/index.js that overrides the localStorage getter with an empty object. This prevents the warning from being emitted, and the tests are passing locally.

[danielmbrasil]

Moving this as ready for review. I think we should possibly also update doc/api/cli.md and doc/api/globals.md, but I'm not sure how to update those docs for now.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (b85505d) to head (e1ec2f3).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #57666      +/-   ##
==========================================
- Coverage   90.24%   90.23%   -0.02%     
==========================================
  Files         630      630              
  Lines      185198   185205       +7     
  Branches    36295    36304       +9     
==========================================
- Hits       167140   167126      -14     
- Misses      10987    10994       +7     
- Partials     7071     7085      +14     

Files with missing lines	Coverage Δ
lib/internal/webstorage.js	100.00% <100.00%> (ø)
src/node_options.cc	85.21% <ø> (-0.13%)	⬇️
src/node_options.h	98.88% <100.00%> (ø)

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mcollina]

A few tests needs fixing but this is good progress!

[danielmbrasil]

This feels a bit hacky, but I wasn’t able to find a better solution. Happy to hear any suggestions.