doc: update example of using await in REPL
#57653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify that the lexical scope of `const` is invalidated when using top-level `await` in REPL. As part of this change also add tests for the documented behavior Fixes: nodejs#45918 Co-authored-by: Antoine du Hamel <[email protected]> Co-authored-by: Dario Piotrowicz <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57653 +/- ##
=======================================
Coverage 90.22% 90.23%
=======================================
Files 630 630
Lines 185055 185055
Branches 36216 36221 +5
=======================================
+ Hits 166975 166976 +1
- Misses 11042 11044 +2
+ Partials 7038 7035 -3 🚀 New features to boost your workflow:
|
aduh95
approved these changes
Mar 28, 2025
aduh95
added
author ready
lpinca
approved these changes
Mar 28, 2025
github-actions
bot
removed
the
request-ci
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 13e3aef |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
I'm just trying to do a bit of caretaking here and trying to resolve this stalled PR: #45939
credit to the original author @deokjinkim 🙂
Clarify that the lexical scope of
constisinvalidated when using top-level
awaitin REPL.As part of this change also add tests for the
documented behavior
Fixes: #45918