-
Notifications
You must be signed in to change notification settings - Fork 31.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: collapse local var scope in loop #57626
base: main
Are you sure you want to change the base?
src: collapse local var scope in loop #57626
Conversation
Review requested:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57626 +/- ##
==========================================
- Coverage 90.23% 90.23% -0.01%
==========================================
Files 630 630
Lines 185055 185055
Branches 36221 36223 +2
==========================================
- Hits 166984 166976 -8
+ Misses 11043 11041 -2
- Partials 7028 7038 +10
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no harm in this, but ideally the commit message would describe the motivation for this change as well, esp. since it is a purely stylistic one
0f15e9d
to
426d089
Compare
Thanks, I edited |
This change narrows the scope of local variables to within the loop to improve code clarity and reduce the risk of variable misuse. Although purely stylistic, it helps with maintainability.