Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "assert,util: revert recursive breaking change" #57622

Merged

Conversation

BridgeAR
Copy link
Member

This reverts commit 575784b.

This was an intentional commit at that time to make a bigger PR not breaking. This should in the real world never have a negative impact, since the algorithm somewhat works more correct with this change and it would very likely have resulted in a difference in user code, if this case really exists.

@BridgeAR BridgeAR added the semver-major PRs that contain breaking changes and should be released in the next major version. label Mar 25, 2025
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Mar 25, 2025
@BridgeAR BridgeAR force-pushed the assert-early-recursion-detection branch from 30cd8a8 to 7647603 Compare March 25, 2025 18:03
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (a4f556f) to head (7647603).
Report is 32 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #57622      +/-   ##
==========================================
- Coverage   90.24%   90.22%   -0.02%     
==========================================
  Files         630      630              
  Lines      185129   185058      -71     
  Branches    36238    36219      -19     
==========================================
- Hits       167064   166969      -95     
- Misses      11045    11048       +3     
- Partials     7020     7041      +21     
Files with missing lines Coverage Δ
lib/internal/util/comparisons.js 99.63% <100.00%> (+<0.01%) ⬆️

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BridgeAR BridgeAR added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 2, 2025
@nodejs-github-bot
Copy link
Collaborator

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 2, 2025
@nodejs-github-bot
Copy link
Collaborator

@BridgeAR BridgeAR added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 2, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 2, 2025
@nodejs-github-bot nodejs-github-bot merged commit 4abad07 into nodejs:main Apr 2, 2025
63 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 4abad07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants