readline: fix unicode line separators being ignored

[dario-piotrowicz]

Fixes #22448

[lpinca]

I'm fine with this but it might be a breaking change.

[dario-piotrowicz]

I'm fine with this but it might be a breaking change.

Yes, I was thinking the same thing, but wanted to hear y'all thoughts on it 🙂
(and unfortunately until this gets merged today I think I'm too late for making it into v24 right? 😓 ... unless it gets postponed... 🤔 )

[lpinca]

(PS: maybe I should just not compare it to the result of the regexp splitting but add the expected array in the test instead 🤔)

Yes, I think it would remove confusion and be more readable.

(and unfortunately until this gets merged today I think I'm too late for making it into v24 right? 😓 ... unless it #57057 (comment)... 🤔 )

Perhaps, but it does not matter much, it will eventually be added to v25, it will just have to wait longer.

[lpinca]

I added the semver-major label as a precaution. If you think it is not necessary, feel free to remove it.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (ffc1cf6) to head (9619d97).
Report is 98 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #57591   +/-   ##
=======================================
  Coverage   90.22%   90.23%           
=======================================
  Files         630      630           
  Lines      185149   185136   -13     
  Branches    36236    36238    +2     
=======================================
- Hits       167058   167049    -9     
- Misses      11035    11043    +8     
+ Partials     7056     7044   -12     

Files with missing lines	Coverage Δ
lib/internal/readline/interface.js	96.97% <100.00%> (+0.01%)	⬆️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65936/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66048/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66058/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66114/