-
Notifications
You must be signed in to change notification settings - Fork 31.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: disable abseil deadlock detection #57582
Merged
Merged
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abseil deadlock detection is reporting false positives in tests. Disable it for now.
Review requested:
|
anonrig
approved these changes
Mar 21, 2025
targos
approved these changes
Mar 21, 2025
This comment was marked as off-topic.
This comment was marked as off-topic.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57582 +/- ##
==========================================
- Coverage 90.22% 90.22% -0.01%
==========================================
Files 630 630
Lines 185045 185055 +10
Branches 36243 36247 +4
==========================================
+ Hits 166961 166963 +2
- Misses 11034 11037 +3
- Partials 7050 7055 +5
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Mar 21, 2025
Windows build error:
Looks like we need this change from 3d1fe71#diff-7ec0a6942f03ad6ff24215a31b1b45a378ee21b2cba5f79937281c5f5528d2bf |
targos
approved these changes
Mar 21, 2025
6 tasks
lpinca
approved these changes
Mar 22, 2025
RafaelGSS
approved these changes
Mar 23, 2025
StefanStojanovic
approved these changes
Mar 24, 2025
RaisinTen
approved these changes
Mar 24, 2025
Landed in 78af51c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build
Issues and PRs related to build files or the CI.
c++
Issues and PRs that require attention from people who are familiar with C++.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abseil deadlock detection is reporting false positives in tests in V8.
Abseil mutexes are not used in node core, so disable it for now.
Refs: nodejs/node-v8#301