src: initialize privateSymbols for per_context #57479
Merged
+59
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
jazelly
force-pushed
the
expose-isolate-data
branch
2 times, most recently
from
4044d5d to
4c9445f
Compare
jazelly
changed the title
jazelly
force-pushed
the
expose-isolate-data
branch
from
4c9445f to
f4643b9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57479 +/- ##
=======================================
Coverage 90.23% 90.23%
=======================================
Files 630 630
Lines 185129 185077 -52
Branches 36234 36222 -12
=======================================
- Hits 167049 167008 -41
- Misses 11037 11039 +2
+ Partials 7043 7030 -13
🚀 New features to boost your workflow:
|
github-actions
bot
removed
the
request-ci
legendecas
reviewed
Mar 17, 2025
jazelly
added
blocked
jazelly
force-pushed
the
expose-isolate-data
branch
from
f4643b9 to
0b6c017
Compare
jazelly
changed the title
jazelly
force-pushed
the
expose-isolate-data
branch
from
0b6c017 to
22cdade
Compare
legendecas
reviewed
Mar 25, 2025
jazelly
force-pushed
the
expose-isolate-data
branch
from
22cdade to
e518bf4
Compare
legendecas
reviewed
Mar 25, 2025
github-actions
bot
removed
the
request-ci
github-actions
bot
added
the
request-ci-failed
Failed to start CI⚠ Commits were pushed since the last approving review: ⚠ - src: initialize privateSymbols for per_context ⚠ - fix: MessagePort::MoveToContext crash ⚠ - fix: check isolate_data when InitializePrivateSymbols ⚠ - maybe local for initialize ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/14195293697 |
aduh95
reviewed
Apr 2, 2025
Comment on lines
+618
to
+620
| // To initialize the per-context binding exports, a non-nullptr isolate_data | ||
| // is needed | ||
| CHECK(isolate_data); |
There was a problem hiding this comment.
Do we need this CHECK given that we have it also in InitializePrivateSymbols?
There was a problem hiding this comment.
I think they guard in different levels. InitializePrivateSymbols checks that it must be invoked with a non-null isolate_data. Here, it checks that if GetPerContextExports is invoked the "first time" (like in node_mksnapshot), the isolate_data must not be null.
legendecas
approved these changes
Apr 2, 2025
legendecas
added
request-ci
github-actions
bot
removed
the
request-ci
jazelly
added
author ready
aduh95
added
needs-ci
nodejs-github-bot
removed
the
commit-queue
|
Landed in 79eddc6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases,
per_contextfiles need to access privateSymbols. This commit letsGetPerContextExportsto be able to pass downIsolateDatatoInitializePrimordials, so it can compileper_contextfiles withprivateSymbolsfromIsolateData.With this change we can access
privateSymbolsinper_context/domexception.jslike