Skip to content

watch: check parent and child path properly #57425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2025
Merged

watch: check parent and child path properly #57425

merged 1 commit into from
Apr 6, 2025

Conversation

jazelly
Copy link
Member

@jazelly jazelly commented Mar 12, 2025

Fixes: #57422

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 12, 2025
@jazelly jazelly force-pushed the fix-57422 branch 3 times, most recently from bb7f643 to 7a81702 Compare March 12, 2025 14:26
@jakecastelli jakecastelli added the watch-mode Issues and PRs related to watch mode label Mar 12, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.23%. Comparing base (59f00d7) to head (dc04bc4).
Report is 165 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/watch_mode/files_watcher.js 90.90% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57425      +/-   ##
==========================================
+ Coverage   90.21%   90.23%   +0.01%     
==========================================
  Files         629      629              
  Lines      185126   184963     -163     
  Branches    36225    36223       -2     
==========================================
- Hits       167016   166900     -116     
+ Misses      11055    11019      -36     
+ Partials     7055     7044      -11
Files with missing lines Coverage Δ
lib/internal/watch_mode/files_watcher.js 89.20% <90.90%> (-0.07%) ⬇️

... and 48 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jazelly jazelly force-pushed the fix-57422 branch 2 times, most recently from a9aa5b0 to 711c301 Compare March 12, 2025 23:50
@jazelly jazelly added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 13, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 13, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65711/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65713/

@jazelly jazelly added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 14, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 14, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65731/

@jakecastelli
Copy link
Member

Hi folks @nodejs/build - could you take a look at this failure fatal error C1060: compiler is out of heap space [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers_host.vcxproj] from https://ci.nodejs.org/job/node-compile-windows/60923/nodes=win-vs2022-arm64/

aduh95
aduh95 approved these changes Mar 15, 2025
View reviewed changes
@jazelly jazelly added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 16, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 16, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65780/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65789/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 16, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65795/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65815/

@richardsimko richardsimko mentioned this pull request Mar 18, 2025
Closed
@jazelly jazelly added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 4, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 4, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66016/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66067/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66072/

@aduh95 aduh95 merged commit 8456a12 into nodejs:main Apr 6, 2025
62 of 63 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Apr 6, 2025

Landed in 8456a12

JonasBa pushed a commit to JonasBa/node that referenced this pull request Apr 11, 2025
@jazelly @jakecastelli @JonasBa
watch: check parent and child path properly
89e9119 
Co-authored-by: Jake Yuesong Li <[email protected]>
PR-URL: nodejs#57425
Fixes: nodejs#57422
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig

@jasnell jasnell

@MoLow MoLow

@BridgeAR BridgeAR

@aduh95 aduh95

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. watch-mode Issues and PRs related to watch mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Watch not working on paths with overlap
8 participants
@jazelly @nodejs-github-bot @jakecastelli @aduh95 @jasnell @anonrig @MoLow @BridgeAR