util: fix parseEnv handling of invalid lines

[AugustinMauroy]

This PR fixes an issue with util.parseEnv() where invalid lines in the input were being incorrectly concatenated into key names instead of being skipped. The fix ensures that lines without an equals sign are properly skipped during parsing

Fixes: #56775

[anonrig]

Nice work!

Even though this test pass, I strongly recommend adding as much as comment possible while simplifying your code. Our parser is already complex (due to not using a regex) and it would help a lot if we know why such decision is taken in the parser.

[codecov]

Codecov Report

Attention: Patch coverage is 83.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 90.23%. Comparing base (1540fc6) to head (6719205).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_dotenv.cc	83.33%	3 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #56778      +/-   ##
==========================================
- Coverage   90.23%   90.23%   -0.01%     
==========================================
  Files         630      630              
  Lines      185288   185295       +7     
  Branches    36344    36339       -5     
==========================================
- Hits       167203   167199       -4     
- Misses      11006    11009       +3     
- Partials     7079     7087       +8     

Files with missing lines	Coverage Δ
src/node_dotenv.cc	85.20% <83.33%> (+1.60%)	⬆️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[AugustinMauroy]

Yup yagizz, I had tried to apply yours suggestions. I'm reaching my limit in C++. So I hope that this time if it's good.

[anonrig]

Yup yagizz, I had tried to apply yours suggestions. I'm reaching my limit in C++. So I hope that this time if it's good.

I see lots of changes unrelated to your PR. Can you revert everything that is unrelated to your change?

[AugustinMauroy]

Bump @anonrig 👋

[anonrig]

Bump @anonrig 👋

@AugustinMauroy the tests are failing

[AugustinMauroy]

@AugustinMauroy the tests are failing

How to run test that fail ?? I din't get what should I do

[targos]

@aduh95 Maybe you could help here? The failure is specific to directories with special chars.

[mertcanaltin]

@AugustinMauroy the tests are failing

How to run test that fail ?? I din't get what should I do

This should work make test-only (for c and js)

if it is a specific js test ./node test-name.js

for more:
https://github.com/nodejs/node/blob/main/BUILDING.md#running-tests

[AugustinMauroy]

Thanks mert 🫶🏻

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65490/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65502/

[aduh95]

nit: Wouldn't it make more sense to put the content here rather in a fixture file?

[AugustinMauroy]

The rest of tests use an fixture so I just do it as same

[AugustinMauroy]

@anonrig any new ?

I will take a look at it soon, but I'm unblocking in case there is someone who can review this faster.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65941/

[aduh95]

This needs a rebase to fix the conflict

[AugustinMauroy]

I'll do that !