-
Notifications
You must be signed in to change notification settings - Fork 31.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: update winget manifest on new release #56774
base: main
Are you sure you want to change the base?
Conversation
Review requested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @nodejs/build @nodejs/releasers
So I guess the question is, who is volunteering to keep this running on an ongoing basis? Unless there is interest from @nodejs/platform-windows I don't believe that the current Build WG and/or Release WG will be able to commit to this. We are not able, for example, to commit to maintain packages for popular Linux distributions and/or Homebrew on macOS and this is no different. |
@ovflowd this seems like the same category of change as nodejs/nodejs.org#7296 (review) ? |
FWIW I'm maintaining the Node.js packages for NixOS, and currently the process is rather manual – everytime there's a new release out, I'm opening a PR from my own fork. I would happily volunteer to move that work to a GHA workflow if there's support for it (or at least no objections :P), once we have a working integration it might ease up adding more. |
Possibly, but if the question here is who is going to maintain this, quite sure not the Website team. |
I just meant that it's vendor-specific code, which in the linked PR you indicated you don't think should be in the project. |
Description
This PR proposes to add a GitHub action for submitting the latest stable release to WinGet as it gets published. microsoft/winget-create is used as the tool for generating and submitting the new manifests. The implementation assumes that the Installer URLs at
https://nodejs.org/dist/
are available as soon as the release is published at GitHub.Steps needed from maintainers
If the maintainers approve of these changes, they will need to do the following before merging this PR:
public_repo
scope from the user account where the fork exists.WINGET_GITHUB_TOKEN
For reference, maintainers may see similar implemented actions in the following repos:
microsoft/terminal, microsoft/PowerToys, microsoft/DevHome, coder/coder
Validation
Validated the action works as expected in a test repo. See the run https://github.com/mdanish-kh/test-wingetcreate/actions/runs/12976977036/job/36189859568