Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update simdutf to 6.4.2 #56764

Merged
merged 1 commit into from
Apr 8, 2025
Merged

deps: update simdutf to 6.4.2 #56764

merged 1 commit into from
Apr 8, 2025

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Jan 26, 2025

This is an automated update of simdutf to 6.4.2.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Jan 26, 2025
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jan 26, 2025
@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-simdutf branch from fffebb7 to eba830c Compare February 2, 2025 00:32
@nodejs-github-bot nodejs-github-bot changed the title deps: update simdutf to 6.1.1 deps: update simdutf to 6.1.2 Feb 2, 2025
@nodejs-github-bot nodejs-github-bot changed the title deps: update simdutf to 6.1.2 deps: update simdutf to 6.2.0 Feb 9, 2025
@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-simdutf branch from eba830c to aa4e6a8 Compare February 9, 2025 00:33
@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-simdutf branch from aa4e6a8 to 59195af Compare February 16, 2025 00:34
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2025
@nodejs-github-bot

This comment was marked as outdated.

@targos
Copy link
Member

targos commented Feb 19, 2025

Note that #57114 will revert this change as we will then depend on V8's version of simdutf.

@richardlau
Copy link
Member

Note that #57114 will revert this change as we will then depend on V8's version of simdutf.

We should probably land this anyway so it can be backported to earlier release lines?

After #57114 will that mean we won't get simdutf updates in older release lines since we'll no longer be updating on main? Does it matter?

@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-simdutf branch from 59195af to 2646258 Compare February 23, 2025 00:34
@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-simdutf branch 2 times, most recently from 41aee4f to a44f583 Compare March 9, 2025 00:28
@nodejs-github-bot nodejs-github-bot changed the title deps: update simdutf to 6.2.0 deps: update simdutf to 6.3.1 Mar 9, 2025
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. lts-watch-v18.x PRs that may need to be released in v18.x. lts-watch-v20.x PRs that may need to be released in v20.x labels Mar 14, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 14, 2025
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator Author

@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-simdutf branch from a44f583 to fd93a6b Compare March 16, 2025 00:35
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 16, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 16, 2025
@nodejs-github-bot
Copy link
Collaborator Author

@nodejs-github-bot nodejs-github-bot changed the title deps: update simdutf to 6.3.1 deps: update simdutf to 6.4.0 Mar 23, 2025
@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-simdutf branch from fd93a6b to df7764a Compare March 23, 2025 00:36
@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-simdutf branch from df7764a to 634ea94 Compare March 30, 2025 00:36
@nodejs-github-bot
Copy link
Collaborator Author

@nodejs-github-bot nodejs-github-bot changed the title deps: update simdutf to 6.4.0 deps: update simdutf to 6.4.2 Apr 6, 2025
@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-simdutf branch from 634ea94 to 201f7ec Compare April 6, 2025 00:36
@aduh95 aduh95 force-pushed the actions/tools-update-simdutf branch from 201f7ec to 634ea94 Compare April 7, 2025 21:14
@nodejs-github-bot
Copy link
Collaborator Author

@aduh95 aduh95 merged commit 17c65d1 into main Apr 8, 2025
65 checks passed
@aduh95 aduh95 deleted the actions/tools-update-simdutf branch April 8, 2025 11:28
@aduh95
Copy link
Contributor

aduh95 commented Apr 8, 2025

Landed in 17c65d1

JonasBa pushed a commit to JonasBa/node that referenced this pull request Apr 11, 2025
PR-URL: nodejs#56764
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. lts-watch-v18.x PRs that may need to be released in v18.x. lts-watch-v20.x PRs that may need to be released in v20.x needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants