src: use non-deprecated ares_set_servers_csv API

[targos]

Refs: #52464

[nodejs-github-bot]

Review requested:

• @nodejs/net

[targos]

@nodejs/cpp-reviewers

[targos]

=== release test-dns ===
Path: parallel/test-dns
Error: --- stderr ---
node:assert:127
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

  [
    '4.4.4.4',
    '2001:4860:4860::8888',
    '103.238.225.181:666',
-   '[fe80::483a:5aff:fee6:1f04]:666',
-   'fe80::483a:5aff:fee6:1f04'
  ]

    at Object.<anonymous> (/home/runner/work/node/node/node/test/parallel/test-dns.js:137:8)
    at Module._compile (node:internal/modules/cjs/loader:1739:14)
    at Object..js (node:internal/modules/cjs/loader:1904:10)
    at Module.load (node:internal/modules/cjs/loader:1473:32)
    at Function._load (node:internal/modules/cjs/loader:1285:12)
    at TracingChannel.traceSync (node:diagnostics_channel:322:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:234:24)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:151:5)
    at node:internal/main/run_main_module:33:47 {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: [ '4.4.4.4', '2001:4860:4860::8888', '103.238.225.181:666' ],
  expected: [
    '4.4.4.4',
    '2001:4860:4860::8888',
    '103.238.225.181:666',
    '[fe80::483a:5aff:fee6:1f04]:666',
    'fe80::483a:5aff:fee6:1f04'
  ],
  operator: 'deepStrictEqual'
}

Node.js v24.0.0-pre
Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /home/runner/work/node/node/node/test/parallel/test-dns.js

I didn't get this failure locally (ran tools/test.py dns).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.50%. Comparing base (bf3bc4e) to head (75c4298).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #56451      +/-   ##
==========================================
- Coverage   88.54%   88.50%   -0.04%     
==========================================
  Files         657      657              
  Lines      190765   190759       -6     
  Branches    36611    36602       -9     
==========================================
- Hits       168908   168832      -76     
- Misses      15036    15124      +88     
+ Partials     6821     6803      -18     

Files with missing lines	Coverage Δ
src/cares_wrap.cc	60.72% <100.00%> (-4.52%)	⬇️

... and 34 files with indirect coverage changes

[targos]

csv passed to cares is 4.4.4.4:53,[2001:4860:4860::8888]:53,103.238.225.181:666,[fe80::483a:5aff:fee6:1f04]:666,[fe80::483a:5aff:fee6:1f04]:53. Seems correct to me.

[targos]

Here's the test:

node/test/parallel/test-dns.js

Lines 122 to 137 in 72537f5

	const ports = [
	'4.4.4.4:53',
	'[2001:4860:4860::8888]:53',
	'103.238.225.181:666',
	'[fe80::483a:5aff:fee6:1f04]:666',
	'[fe80::483a:5aff:fee6:1f04]',
	];
	const portsExpected = [
	'4.4.4.4',
	'2001:4860:4860::8888',
	'103.238.225.181:666',
	'[fe80::483a:5aff:fee6:1f04]:666',
	'fe80::483a:5aff:fee6:1f04',
	];
	dns.setServers(ports);
	assert.deepStrictEqual(dns.getServers(), portsExpected);

[lemire]

@targos Section 6 of the RFC 5952 suggests that brackets are optional.

https://www.rfc-editor.org/rfc/rfc5952

There are many different ways to combine IPv6 addresses and port
   numbers that are represented in text.  Examples are shown below.

   o  [2001:db8::1]:80

   o  2001:db8::1:80

   o  2001:db8::1.80

   o  2001:db8::1 port 80

   o  2001:db8::1p80

   o  2001:db8::1#80

[targos]

This is what ares_get_servers_csv returns: 4.4.4.4:53,[2001:4860:4860::8888]:53,103.238.225.181:666. How did we lose two of the servers?

[targos]

Hello @bradh352, I hope you don't mind the ping. Am I missing something obvious about how the API works?

[bradh352]

my guess is we're throwing link-local addresses away as invalid if it doesn't specify the interface which is required. You need %eth0 or some similar valid interface name for the system for link-local dns servers.