doc: HTTP Module request.reusedSocket documentation sample code error fix #55478
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
doc
Ethan-Arrowood
approved these changes
Oct 21, 2024
|
Hi! Can you please amend your commit message to have a valid subsystem? In this case, it should begin with |
|
Sure
…On Mon, 21 Oct, 2024, 4:11 pm Aviv Keller, ***@***.***> wrote:
Hi! Can you please amend your commit message to have a valid subsystem? In
this case, it should begin with doc:
—
Reply to this email directly, view it on GitHub
<#55478 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/APVADS6M3P6HRAWVKEK4X3DZ4TK6JAVCNFSM6AAAAABQJKLBW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRWGI4TKNRVHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
koushil-mankali
changed the title
|
You only changed the PR title, try using |
… error, their is no agent variable declared in the sample code but that agent variable is used in the request object, which is really confusing for the reader, from where does the agent variable is taken. So, fixed the code by adding the agent variable and taking the http.agent initalization.
koushil-mankali
force-pushed
the
patch-1
branch
from
3bb6963 to
91fa47a
Compare
Done, amended commit. |
|
done, amended the commit.
Thank you,
Koushil Mankali
…On Mon, Oct 21, 2024 at 8:01 PM Ethan Arrowood ***@***.***> wrote:
You only changed the PR title, try using git commit --amend
—
Reply to this email directly, view it on GitHub
<#55478 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/APVADS6OHOL37DA2EFLYKDLZ4UF2RAVCNFSM6AAAAABQJKLBW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRWHA2TMMRXGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
M.koushil
|
lpinca
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc: HTTP Module request.reusedSocket documentation sample code has a error, their is no agent variable declared in the sample code but that agent variable is used in the request object, which is really confusing for the reader, from where does the agent variable is taken.
So, fixed the code by adding the agent variable and taking the http.agent initalization.