buffer: cleanup handling different types buffers #54439
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
buffer
ronag
commented
Aug 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #54439 +/- ##
==========================================
- Coverage 87.33% 87.27% -0.06%
==========================================
Files 648 648
Lines 182321 182331 +10
Branches 34971 34968 -3
==========================================
- Hits 159222 159135 -87
- Misses 16374 16455 +81
- Partials 6725 6741 +16
|
avivkeller
reviewed
Aug 19, 2024
Comment on lines
-47
to
-50
| TypedArrayPrototypeGetBuffer, | ||
| TypedArrayPrototypeGetByteLength, | ||
| TypedArrayPrototypeGetByteOffset, | ||
| TypedArrayPrototypeGetLength, |
There was a problem hiding this comment.
Are these no longer needed (in regards to primordials)?
wa-Nadoo
reviewed
Aug 19, 2024
| 'Buffer', | ||
| 'TypedArray', | ||
| 'DataView', | ||
| 'ArrayBuffer', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.