Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: Server should generate lazily create sessionIdContext #54298

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Aug 10, 2024

Probably not significant as you usually only start a Server per instance, but providing it for discussion.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tls Issues and PRs related to the tls subsystem. labels Aug 10, 2024
@Uzlopak Uzlopak force-pushed the lazy-session-id-context branch from 9d2e86e to 5879fc1 Compare August 10, 2024 02:00
Copy link

codecov bot commented Aug 10, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.09%. Comparing base (3cbeed8) to head (5879fc1).
Report is 257 commits behind head on main.

Files with missing lines Patch % Lines
lib/_tls_wrap.js 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #54298      +/-   ##
==========================================
- Coverage   87.11%   87.09%   -0.02%     
==========================================
  Files         647      647              
  Lines      181773   181802      +29     
  Branches    34889    34889              
==========================================
- Hits       158347   158340       -7     
- Misses      16739    16763      +24     
- Partials     6687     6699      +12     
Files with missing lines Coverage Δ
lib/_tls_wrap.js 93.35% <92.85%> (-0.04%) ⬇️

... and 33 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants