Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: change the if statement to a switch statement for code readability. #54148

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

src: change the if statement to a switch statement for code readability. #54148

wants to merge 1 commit into from

Conversation

kmk324
Copy link
Contributor

@kmk324 kmk324 commented Jul 31, 2024 •
edited
Loading

src: change the if statement to a switch statement for code readability in node_zlib.cc

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib subsystem. labels Jul 31, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.07%. Comparing base (67bc6a4) to head (b768d18).
Report is 218 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #54148   +/-   ##
=======================================
  Coverage   87.07%   87.07%           
=======================================
  Files         643      643           
  Lines      181580   181580           
  Branches    34894    34890    -4     
=======================================
+ Hits       158103   158114   +11     
+ Misses      16749    16737   -12     
- Partials     6728     6729    +1
Files Coverage Δ
src/node_zlib.cc 79.11% <100.00%> (+0.61%) ⬆️

... and 28 files with indirect coverage changes

@daeyeon daeyeon added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 1, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 1, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60782/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61420/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daeyeon daeyeon daeyeon approved these changes

@aymen94 aymen94 aymen94 approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kmk324 @nodejs-github-bot @daeyeon @aymen94