-
Notifications
You must be signed in to change notification settings - Fork 31.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add documentation for process.traceProcessWarnings #53641
base: main
Are you sure you want to change the base?
docs: add documentation for process.traceProcessWarnings #53641
Conversation
021aa19
to
1d1c74b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are only my suggestions, and are not blocking, nor do they have the power to.
doc/api/process.md
Outdated
## `process.traceProcessWarnings` | ||
|
||
<!-- YAML | ||
added: v6.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be the exact version, rather than the .x semver
doc/api/process.md
Outdated
The `process.traceProcessWarnings` property indicates whether the `--trace-warnings` flag is set on the current Node.js process. This property allows programmatic control over the tracing of warnings, enabling or disabling stack traces for warnings at runtime. | ||
|
||
Setting this property to `true` enables the tracing of warnings, akin to launching the process with the `--trace-warnings` command-line option. Conversely, setting it to `false` disables the tracing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be condensed, as some information is repeated (such as what the API does)
1d1c74b
to
f83063f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep in mind, I'm just a triage member. When the collaborators get a chance to check out this PR, they will be able to provide better reviews than I.
This is not approving nor blocking.
doc/api/process.md
Outdated
|
||
The `process.traceProcessWarnings` property indicates whether the `--trace-warnings` flag is set on the current Node.js process. This property allows programmatic control over the tracing of warnings, enabling or disabling stack traces for warnings at runtime. | ||
|
||
```mjs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a js
block, not mjs
.
@redyetidev |
f83063f
to
bb1000d
Compare
doc/api/process.md
Outdated
|
||
* {boolean} | ||
|
||
The `process.traceProcessWarnings` property indicates whether the `--trace-warnings` flag is set on the current Node.js process. This property allows programmatic control over the tracing of warnings, enabling or disabling stack traces for warnings at runtime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The `process.traceProcessWarnings` property indicates whether the `--trace-warnings` flag is set on the current Node.js process. This property allows programmatic control over the tracing of warnings, enabling or disabling stack traces for warnings at runtime. | |
The `process.traceProcessWarnings` property indicates whether the `--trace-warnings` flag | |
is set on the current Node.js process. This property allows programmatic control over the | |
tracing of warnings, enabling or disabling stack traces for warnings at runtime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out and I made the change you have requested.
bb1000d
to
d647636
Compare
@jasnell Could you please check and review this PR again when you have a moment? Thanks |
Add documentation for the
process.traceProcessWarnings
property in the process module. This property allows for programmatic control of warning trace settings in Node.js applications and was previously undocumented despite being available since Node.js v6.x.resolves #53514