Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: avoid repl.setupHistory() blocks node exit after repl closed #52587

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

lib: avoid repl.setupHistory() blocks node exit after repl closed #52587

wants to merge 4 commits into from
+18 −0

Conversation

lucshi
Copy link

@lucshi lucshi commented Apr 19, 2024

Fixes: #52386

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Apr 19, 2024
@cola119
Copy link
Member

cola119 commented Apr 20, 2024

@lucshi Can you add tests for the change?

@cola119 cola119 added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 20, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 20, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58546/

@lucshi
Copy link
Author

lucshi commented Apr 22, 2024

@lucshi Can you add tests for the change?

Sure I will add a test. Thanks!

@lucshi
Copy link
Author

lucshi commented Apr 23, 2024

@cola119 Could you please take a look? Thank!

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58628/

@cola119
Copy link
Member

cola119 commented Apr 23, 2024

Can you fix the linter errors?

@lucshi
Copy link
Author

lucshi commented Apr 24, 2024

Can you fix the linter errors?

Sure, just noticed the errors. Done.

@cola119 cola119 added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 24, 2024
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Apr 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Failed to start CI
   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/8824871644

@lucshi
Copy link
Author

lucshi commented Apr 25, 2024

@node/lib

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58835/

@lucshi
Copy link
Author

lucshi commented Jun 4, 2024

Hi @cola119, Could you please take a look at this? Thanks!

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63400/

BridgeAR
BridgeAR reviewed Mar 17, 2025
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK an alternative should be to only write sync. That would also make sure things are written properly and it is closed.

@aduh95 aduh95 removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR left review comments

@juanarbol juanarbol juanarbol approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

After calling setupHistory, the program continues to run even after the REPL is closed.
6 participants
@lucshi @cola119 @nodejs-github-bot @BridgeAR @juanarbol @aduh95