-
-
Notifications
You must be signed in to change notification settings - Fork 32k
lib: reset the cwd cache before execution #49684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d6d6eab
lib: reset the cwd cache before execution
arcanis 7b2cfac
test: add a cwd cache bust test
arcanis f02a6ab
fix lint
arcanis 851b29a
leverage addSerializeCallback
arcanis a74d68d
leverage spawnSyncAndExitWithoutError
arcanis 3736efe
use trim
arcanis 9b9b520
Update test/parallel/test-snapshot-cwd.js
arcanis d4b132b
Update test/parallel/test-snapshot-cwd.js
arcanis 12eab3d
Update test/parallel/test-snapshot-cwd.js
arcanis e2109f7
Update test/parallel/test-snapshot-cwd.js
arcanis f02b286
Update test-snapshot-cwd.js
arcanis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
const { | ||
setDeserializeMainFunction, | ||
} = require('v8').startupSnapshot; | ||
|
||
// To make sure the cwd is present in the cache | ||
process.cwd(); | ||
|
||
setDeserializeMainFunction(() => { | ||
console.log(process.cwd()); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
'use strict'; | ||
|
||
// This tests that user land snapshots works when the instance restored from | ||
// the snapshot is launched with -p and -e | ||
|
||
require('../common'); | ||
const { spawnSyncAndExitWithoutError } = require('../common/child_process'); | ||
const tmpdir = require('../common/tmpdir'); | ||
const fixtures = require('../common/fixtures'); | ||
const fs = require('fs'); | ||
const path = require('path'); | ||
|
||
tmpdir.refresh(); | ||
const blobPath = tmpdir.resolve('snapshot.blob'); | ||
const file = fixtures.path('snapshot', 'cwd.js'); | ||
|
||
const subdir = path.join(tmpdir.path, 'foo'); | ||
arcanis marked this conversation as resolved.
Show resolved
Hide resolved
|
||
fs.mkdirSync(subdir); | ||
|
||
{ | ||
// Create the snapshot. | ||
spawnSyncAndExitWithoutError(process.execPath, [ | ||
'--snapshot-blob', | ||
blobPath, | ||
'--build-snapshot', | ||
file, | ||
], { | ||
cwd: tmpdir.path, | ||
encoding: 'utf8' | ||
}, { | ||
status: 0, | ||
}); | ||
} | ||
|
||
{ | ||
// Check a custom works. | ||
arcanis marked this conversation as resolved.
Show resolved
Hide resolved
arcanis marked this conversation as resolved.
Show resolved
Hide resolved
|
||
spawnSyncAndExitWithoutError(process.execPath, [ | ||
'--snapshot-blob', | ||
blobPath, | ||
file, | ||
], { | ||
cwd: subdir, | ||
encoding: 'utf8' | ||
}, { | ||
status: 0, | ||
trim: true, | ||
stdout: subdir | ||
arcanis marked this conversation as resolved.
Show resolved
Hide resolved
|
||
}); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.