Skip to content

Read all results for subdirectories in opendir #48829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Read all results for subdirectories in opendir #48829

wants to merge 2 commits into from
+15 −11

Conversation

mdouglass
Copy link
Contributor

Fixes #48820

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jul 18, 2023
@mdouglass mdouglass mentioned this pull request Jul 18, 2023
Closed
mdouglass added 2 commits July 18, 2023 11:55
@mdouglass
fs: read all results for subdirectories in opendir

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
0bab5d8 
Fixes nodejs#48820
@mdouglass
update test to use artificially low bufferSize to demonstrate bug
860657d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fs#opendir does not return all files in subdirectories when bufferSize is less than the directory size
2 participants
@mdouglass @nodejs-github-bot