fs: fix mkdirp return UV_EROFS on read-only fs

[hiimjako]

Fixes: #47098

I tested the changes manually by mounting a read-only fs and trying to create a new folder inside it.
I honestly wouldn't know how to write tests on these changes without mounting a RO file systems during test sets, and I don't know if this is the best solution. If anyone has advice on how to do this, it is welcome

[VoltrexKeyva]

Hey @hiimjako, thank you for considering to contribute.

Your commit (b4a60a3) is pointing at an invalid user, make sure you've configured Git to point to you so that you would be shown as a contributor after your changes are accepted and merged.

A commit pointing to an invalid user can generally be caused by it being committed by the incorrect email address, make sure the user.email config in Git is your primary GitHub email address. You can set the config globally to your primary email address by running:

$ git config --global user.email "<primary email>"

(Replace <primary email> with your primary GitHub email address.)

You can check the Git getting started guide for more information.

---

After all that, force-push the commit to make it point to you.

[hiimjako]

Hi @VoltrexKeyva,

Thanks for the suggestion, I was using another email for other things and I forgot to change it :)

Now it should be right

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/51904/

[anonrig]

Can we simulate a readonly environment and add a test for this? I don't feel comfortable merging this without any tests, unless someone more knowledgable on this matter reviews and approves this PR.

[RafaelGSS]

Thanks for the PR. Please include a test

[hiimjako]

Hi @RafaelGSS,
thanks to the work of @kwaszczuk, a test has been added.
There was a discussion in the issue about which platforms to test, and it was decided that supporting only Linux would be sufficient since uv already maps to the error on each platform.
Does this seem reasonable to you?
Thanks!

[kwaszczuk]

Hey @RafaelGSS, any chance you'll be able to take a look at this PR soon? 🤞

[RafaelGSS]

Do we have a test environment that would enter into this clause? @nodejs/build

[richardlau]

We do not.