fs: change default mode to COPYFILE_FICLONE #47951
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
fs
HinataKah0
commented
May 10, 2023
| @@ -61,6 +62,9 @@ fs.unlinkSync(dest); | |||
| fs.copyFileSync(src, dest, UV_FS_COPYFILE_FICLONE); | |||
| verify(src, dest); | |||
|
|
|||
| // Verify that default mode is COPYFILE_FICLONE. | |||
| assert.strictEqual(getValidMode(null, 'copyFile'), COPYFILE_FICLONE); | |||
There was a problem hiding this comment.
Actually I am not really sure how to test it.
Input is welcomed! 😄
HinataKah0
force-pushed
the
default-COPYFILE_FICLONE
branch
from
843999c to
03af9a5
Compare
HinataKah0
changed the title
|
Ping @nodejs/fs for reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change default value of mode to
COPYFILE_FICLONEinfs.copyFileandfs.copyFileSync.If copy-on-write is not supported, fallback copy mechanism
will be used.
Fixes: #47861
I am aware that the discussion is still very nascent. If we are not going to do this or if we are going in different direction, feel free to close this PR.
TODO: