Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve fsPromises.copyFile() documentation and code example #46917

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

recrack
Copy link
Contributor

@recrack recrack commented Mar 3, 2023

Update the documentation and code example for fsPromises.copyFile()
fs/promises module to provide better guidance and error handling.

@recrack recrack force-pushed the improve-error-handling-fs-promises branch from 6280834 to c115feb Compare March 3, 2023 04:21
@recrack recrack changed the title doc: update fs/promises code example for better error handling doc: Improve fsPromises.copyFile() documentation and code example Mar 3, 2023
@recrack recrack force-pushed the improve-error-handling-fs-promises branch from c115feb to a9253bb Compare March 3, 2023 06:38
@VoltrexKeyva VoltrexKeyva added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Mar 4, 2023
@recrack recrack force-pushed the improve-error-handling-fs-promises branch from a9253bb to e257331 Compare March 6, 2023 05:13
@recrack recrack requested a review from VoltrexKeyva March 6, 2023 07:17
@recrack recrack force-pushed the improve-error-handling-fs-promises branch from e257331 to a319eda Compare March 7, 2023 12:40
@recrack
Copy link
Contributor Author

recrack commented Mar 7, 2023

@VoltrexKeyva could you please bot retry?

@deokjinkim
Copy link
Contributor

deokjinkim commented Mar 8, 2023

@VoltrexKeyva could you please bot retry?

@recrack CI was already executed. Commit title has violation now. Need to replace Improve with improve.

Error: not ok 6 title-format: First word after subsystem(s) in title should be lowercase. (doc: Improve `fsPromises.copyFile()` documentation and code example)

@recrack recrack changed the title doc: Improve fsPromises.copyFile() documentation and code example doc: improve fsPromises.copyFile() documentation and code example Mar 8, 2023
@recrack recrack force-pushed the improve-error-handling-fs-promises branch from a319eda to 5fd58db Compare March 8, 2023 01:05
@recrack
Copy link
Contributor Author

recrack commented Mar 8, 2023

@deokjinkim Thank you for the review. I have completed the modifications.

Update the documentation and code example for `fsPromises.copyFile()`
`fs/promises` module to provide better guidance and error handling.
@recrack recrack force-pushed the improve-error-handling-fs-promises branch from 5fd58db to 7531f11 Compare March 9, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants