Skip to content

Revert "deps: make V8 compilable with older glibc" #45162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2022
Merged

Revert "deps: make V8 compilable with older glibc" #45162

merged 1 commit into from
Oct 27, 2022

Conversation

targos
Copy link
Member

@targos targos commented Oct 25, 2022

This reverts commit 84d455e.

Refs: #45118

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Oct 25, 2022
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 25, 2022
@targos targos mentioned this pull request Oct 25, 2022
Open
7 tasks
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 25, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 25, 2022 •
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/47457/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4942/

@targos targos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 25, 2022
@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/4942/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/4942/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/4942/

@targos targos mentioned this pull request Oct 25, 2022
Open
@lpinca lpinca added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Oct 27, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 27, 2022
@nodejs-github-bot nodejs-github-bot merged commit 466d36e into nodejs:main Oct 27, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 466d36e

@targos targos deleted the revert-glibc branch October 27, 2022 10:25
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@targos @RafaelGSS
Revert "deps: make V8 compilable with older glibc"
1650b3e 
This reverts commit 84d455e.

PR-URL: #45162
Refs: #45118
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@targos @RafaelGSS
Revert "deps: make V8 compilable with older glibc"
f589961 
This reverts commit 84d455e.

PR-URL: #45162
Refs: #45118
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: James M Snell <[email protected]>
ivomusk
ivomusk reviewed Jun 27, 2025
View reviewed changes
Copy link

@ivomusk ivomusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

249b0622d15d67a17fa5ceaee8e36f9f848d226d

ivomusk
ivomusk reviewed Jun 28, 2025
View reviewed changes
Copy link

@ivomusk ivomusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lib/github-comment.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivomusk ivomusk ivomusk left review comments

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@richardlau richardlau richardlau approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@targos @nodejs-github-bot @bnoordhuis @jasnell @gengjiawen @richardlau @BethGriggs @VoltrexKeyva @ivomusk @lpinca