child_process: check for closed pipes after creating socket #38716
+23
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the socket is created, we trigger an empty read to make sure we catch stdio events like closing the stdin file descriptor. Otherwise those events will go undetected until the next stream write. Fixes: nodejs#25131
github-actions
bot
added
child_process
|
Hey @seangoedecke, sorry your PR was not reviewed for so long! Any chance you would be able to rebase on top of |
aduh95
reviewed
Sep 20, 2023
| @@ -447,6 +447,10 @@ ChildProcess.prototype.spawn = function(options) { | |||
| stream.socket = createSocket(this.pid !== 0 ? | |||
| stream.handle : null, i > 0); | |||
|
|
|||
| // Trigger an empty read to check for a closed pipe | |||
| // or the close event will go undetected until next write | |||
There was a problem hiding this comment.
Suggested change
| // or the close event will go undetected until next write | |
| // or the close event will go undetected until next write. |
aduh95
reviewed
Sep 20, 2023
| const fs = require('fs'); | ||
|
|
||
| if (process.argv[2] === 'child') { | ||
| fs.closeSync(0); |
There was a problem hiding this comment.
Any reason to use closeSync(0) rather than process.stdin.end()? If so, can you add a comment?
There was a problem hiding this comment.
as far as I understand the closeSync(0) is used because it needs to immediately close the standard input stream synchronously, however it's really good question why we cannot asynchronous handling of the end of the input stream?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the socket is created, this PR now triggers an empty read to make sure we catch stdio events like closing the stdin file descriptor. Otherwise those events will go undetected until the next stream write.
Fixes: #25131