test: don't remove empty.txt on win32 #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on win32 we use empty.txt in the fixtures directory, otherwise we use a file constructed specifically for this test due to POSIX socket path length limitations, in which case we need to do appropriate cleanup
|
LGTM |
|
Another LGTM. |
|
@rvagg By the way, do you have commit rights? I'd like you to land your patches yourself. |
|
@bnoordhuis sure, is there anything special I need to know about the normal merge procedure? |
|
@rvagg Just the normal commit log as described in CONTRIBUTING.md plus PR-URL and Reviewed-By tags. Basically, what you see when you run |
rvagg
added a commit
that referenced
this pull request
Nov 29, 2014
on win32 we use empty.txt in the fixtures directory, otherwise we use a file constructed specifically for this test due to POSIX socket path length limitations, in which case we need to do appropriate cleanup Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> PR-URL: #2
This was referenced Oct 28, 2020
3 tasks
ghost
mentioned this pull request
1 task
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Mar 1, 2023
Original commit message:
[bigint] Convert BigInt property names to decimal
Hexadecimal/octal/binary BigInt property names should be converted
to decimal, i.e. the following object literals should all be equivalent:
var o = {0xF: 1}, p = {0xFn: 1}, q = {15: 1}, r = {15n: 1}.
Test case by [email protected], uploaded at
https://chromium-review.googlesource.com/c/v8/v8/+/3634937
Fixed: v8:10600
Change-Id: Ie1d8a16e95697cd31cbc0784843779c921ce91fa
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3642302
Reviewed-by: Toon Verwaest <[email protected]>
Commit-Queue: Jakob Kummerow <[email protected]>
Cr-Commit-Position: refs/heads/main@{#80490}
Refs: v8/v8@c875e86
PR-URL: nodejs#46501
Refs: v8/v8@c875e86
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Merged
sungpaks
added a commit
to sungpaks/node
that referenced
this pull request
Jul 29, 2024
Subtest nodejs#1, nodejs#2 of test-node-run.js originally matched the error message "Can't read package.json" on non-existent file. However, the subtests failed on Ubuntu20.04. we found that attempting to run a non-existent script like `node --run foo` using the latest version of node results in an error message like `Can't find “scripts” field in package.json` (on Ubuntu20.04, regardless of whether package.json is present in the subpath or not). So we modified the subtest so that if we match either of the two messages, the test passes.
sungpaks
added a commit
to sungpaks/node
that referenced
this pull request
Jul 29, 2024
Subtest nodejs#1, nodejs#2 of test-node-run.js originally matched the error message "Can't read package.json" on non-existent file. However, the subtests failed on Ubuntu20.04. we found that attempting to run a non-existent script like `node --run foo` using the latest version of node results in an error message like `Can't find “scripts” field in package.json` (on Ubuntu20.04, regardless of whether package.json is present in the subpath or not). So we modified the subtest so that if we match either of the two messages, the test passes.
🤖 Secure-PR-Guard AI Code ReviewAnalysis completed at: 2025-06-28 20:39:59 UTC 🟡 Risk Assessment: MEDIUM
🟢 Low Priority Issues
🔗 Powered by Secure-PR-Guard | 🛡️ OWASP LLM Top 10 Compliant This is an automated review. Please verify critical security findings manually. |
🤖 Secure-PR-Guard AI Code ReviewAnalysis completed at: 2025-06-28 21:19:12 UTC 🟡 Risk Assessment: MEDIUM
🟢 Low Priority Issues
🔗 Powered by Secure-PR-Guard | 🛡️ OWASP LLM Top 10 Compliant This is an automated review. Please verify critical security findings manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take 3: on win32 we use empty.txt in the fixtures directory, otherwise we use a file constructed specifically for this test due to POSIX socket path length limitations, in which case we need to do appropriate cleanup. Cleaning up empty.txt in fixtures causes downstream problems for other tests using it (currently the next test is test-zlib).