test: use common.fixtures.fixturesDir #15854
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
the
code-and-learn
Trott
reviewed
Oct 8, 2017
| const assert = require('assert'); | ||
| const path = require('path'); | ||
| const fs = require('fs'); | ||
| const fn = path.join(common.fixturesDir, 'empty.txt'); | ||
| const fn = path.join(fixturesDir, 'empty.txt'); |
There was a problem hiding this comment.
Hi @tobbik! Welcome, and thanks for this! Can you change this to use fixtures.path() instead of fixtures.fixturesDir? See the documentation at https://github.com/nodejs/node/tree/master/test/common#fixtures-module.
There was a problem hiding this comment.
Hi,
I created a new pull request with the changes as asked for.
#16109
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test