Skip to content

Docs for --permission incorrectly state support for (,) delimiter #58287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jdalton opened this issue May 11, 2025 · 1 comment · Fixed by #58297
Closed

Docs for --permission incorrectly state support for (,) delimiter #58287

jdalton opened this issue May 11, 2025 · 1 comment · Fixed by #58297
Labels
doc Issues and PRs related to the documentations. permission Issues and PRs related to the Permission Model

Comments

@jdalton
Copy link
Member

jdalton commented May 11, 2025 •
edited
Loading

Version

v24.0.1

Platform

MacOsx 15.4.1

Subsystem

No response

What steps will reproduce the bug?

Doc bug:

Docs for --permission incorrectly state support for (,) delimiter.

See https://nodejs.org/api/permissions.html#file-system-permissions

Image

After digging I realized support for the , delimiter was removed:
https://github.com/nodejs/node/blob/v24.0.1/doc/api/cli.md?plain=1#L204

How often does it reproduce? Is there a required condition?

Everytime

What is the expected behavior? Why is that the expected behavior?

The documentation reflects what is supported and possible.

What do you see instead?

Additional information

No response
@jdalton jdalton changed the title Docs for --permission incorrectly state support for (,) delimiter and npx --node-options="--permission" but don't work. Docs for --permission incorrectly state support for (,) delimiter May 12, 2025
@marco-ippolito
Copy link
Member

cc @RafaelGSS

@marco-ippolito marco-ippolito added doc Issues and PRs related to the documentations. permission Issues and PRs related to the Permission Model labels May 12, 2025
@RafaelGSS RafaelGSS mentioned this issue May 12, 2025
Merged
nodejs-github-bot pushed a commit that referenced this issue May 14, 2025
@RafaelGSS
doc: remove comma delimiter mention on permissions doc
f75c960 
PR-URL: #58297
Fixes: #58287
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Edy Silva <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. permission Issues and PRs related to the Permission Model
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: remove comma delimiter mention on permissions doc RafaelGSS/node
2 participants
@jdalton @marco-ippolito