Skip to content

http2: handling errors while submitting settings #16083

Closed
@trivikr

Description

@trivikr

As part of improving http2 test coverage in #14985, I was trying to unit test the following code in submitSettings()

switch (ret) {
case NGHTTP2_ERR_NOMEM:
err = new errors.Error('ERR_OUTOFMEMORY');
process.nextTick(emit, this, 'error', err);
break;
default:
// Some other unexpected error was reported.
if (ret < 0) {
err = new NghttpError(ret);
process.nextTick(emit, this, 'error', err);
}
}

While debugging, I'm not able to step into handle.submitSettings() to check how the value of ret is computed
screen shot 2017-10-07 at 10 01 07 pm

I don't see method submitSettings for handle in the call stack.
This appears to be an issue. Am I missing something? I'm testing on node master branch.

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionIssues that look for answers.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions