-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
allow node-gyp to use open source toolchains on windows #3166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
It is a bit too biased towards propietary toolchains, this will diversify the supported toolchains of node-gyp
ok ruff lint is failing but all other tests pass |
This might significantly increase our support issues. These changes should probably land first on https://github.com/nodejs/gyp-next Please install https://docs.astral.sh/ruff locally because those errors cannot be ignored. |
So you mean it increases the platform support? |
I mean that it will open more https://github.com/nodejs/node-gyp/issues for a volunteer group of maintainers to triage. |
because more people will use node-gyp since it will fix something that was broken? That might be true. Is that the reason why it was not fixed? I will try submitting a patch for gyp-next but it wont be anytime soon, since it is basically a rewrite. |
also with this, you can work with a fork of https://github.com/Kreijstal/node-ffi-napi/tree/master ffi-napi.. since of course it is msvc biased.. |
currently it is the only option on msys2, since broooklyn will never update napi-sys. And koffi.rs does not work in msys2 either |
Checklist
npm install && npm run lint && npm test
passesDescription of change
It is a bit too biased towards propietary toolchains, this will diversify the supported toolchains of node-gyp
fixes #3120
fixes #3079
fixes #1240
fixes #194