fix: remove more forcefully #3113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
macOS on Intel seems to fail but macOS on ARM seems to always pass. I got the same CI test results with unrelated changes on #3114 |
|
ironically it seems similar to the issue i described here. there must be another |
|
@tmm1 Are the forceful removes, basically meaning a repeat (try again), or use a flag for rm? Just peeking in, and looking to help. Thanks! |
|
I've pushed another commit to this PR that adds the |
tmm1
added a commit
to tmm1/vscode
that referenced
this pull request
Jun 3, 2025
improves reliability of builds on windows includes nodejs/node-gyp#3113 and nodejs/node-gyp#3112
deepak1556
pushed a commit
to microsoft/vscode
that referenced
this pull request
Jun 9, 2025
improves reliability of builds on windows includes nodejs/node-gyp#3113 and nodejs/node-gyp#3112
deepak1556
added a commit
to microsoft/vscode
that referenced
this pull request
Jun 9, 2025
* chore: bump node-gyp on windows to 11.2.0 improves reliability of builds on windows includes nodejs/node-gyp#3113 and nodejs/node-gyp#3112 * use preinstalled node-gyp * use bundled node-gyp for subdirs too * chore: revert changes to package-lock.json * chore: rebuild package-lock.json * ci: rebuild cache --------- Co-authored-by: Aman Karmani <[email protected]>
eli-w-king
added a commit
to eli-w-king/vscode
that referenced
this pull request
Jun 9, 2025
* Apply `font-variation-settings` to `suggestWidgetRenderer` * fix patternIndices typo * Import type from xterm/headless Fixes microsoft#248589 * Commented out settings slide * Progress button on last step now says 'Start coding' instead of 'Next' * Update VS Code intro walkthrough final button labels * Update other references * Tiny changes to input hover bar ('x' button) to match code block toolbar (microsoft#250566) Co-authored-by: Joanna Oikawa <[email protected]> * ensure state is modified on any edit applied from the agent (microsoft#250567) * commands: fix potential issue on vscode.dev/edu route (microsoft#250573) Closes microsoft/vscode-dev#1290 * Use Loopback as default _with_ redirect (microsoft#250570) To have the best chance of working. ref microsoft#250547 * redo borders for chat bubbles + hover fixes (microsoft#250569) * some fixes * add back border, fixes arrows up and down * watcher - polish log output (microsoft#250586) * chat - increase timeout for setup waiting when connected to a remote (microsoft#250587) * fix focus on attachments and render attachments (microsoft#250578) * fix render attachments * clean up * chat - add logos to continue buttons (microsoft#250391) * chat - add logos to continue buttons * . * polish toolset schemas (microsoft#250592) fixes microsoft#250417 fixes microsoft#250483 * fix microsoft#250482 (microsoft#250593) * Don't show title in custom title bar if shown in native title bar (microsoft#250596) dont show title in custom title bar if shown in native title bar * Improve gutter menu rendering when no line numbers (microsoft#250597) improve gutter menu rendering when no line numbers * Tools picker updates (microsoft#250600) * use gear-icon for `Configure Tool Sets...` command * sort tools/tool-sets in picker microsoft#250476 * fix microsoft#249863 - Timeout manifest request (microsoft#250601) * Chat does not register agent again when extension re-installed (fix microsoft#250382) (microsoft#250551) * chat - no need to duplicate SVGs (microsoft#250602) The build process will move them to the top level `media` folder * Align "Configure Tool Sets" command (microsoft#250605) * add to view menu * change wording to "Create new..." * ellipsis in title microsoft#250474 * chat - continue installation independent of sign-in result (microsoft#250606) * PLG: Guide users to continue or finish setup (microsoft/vscode-copilot#16775) (microsoft#250614) * Review usages of `EditorOption.lineHeight` (microsoft#248794) (microsoft#250625) * Dropdown / Select Box should follow `window.menuStyle` (microsoft#250627) Dropdown / Select Box should follow `window.menuSytle` * Browser popup block is obtrusive when refreshing the page with the process explorer open (fix microsoft#250469) (microsoft#250618) * Browser popup block is obtrusive when refreshing the page with the process explorer open (fix microsoft#250469) * fix ci * fix ci * windows - for now show OS context menu in title (workaround microsoft#250626) (microsoft#250631) * Use `y` and `n` keybindings for keep- and undo-changes. (microsoft#250635) fixes microsoft#248041 (comment) * Fix enum order for menu style (microsoft#250387) fix enum order for menu style * Use Copilot instead of Chat for action title (microsoft#250641) Use Copilot instead of Chat * Auto-generated baselines by 1ES Pipeline Templates (microsoft#250340) Updated for https://dev.azure.com/monacotools/a6d41577-0fa3-498e-af22-257312ff0545/_build?definitionId=111 by using baselines generated in https://dev.azure.com/monacotools/a6d41577-0fa3-498e-af22-257312ff0545/_build/results?buildId=340919 Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> * don't hardcode Copilot name (microsoft#250645) * only apply graceful kill setting to linux/macOS (microsoft#250639) * update stable experiment groups allocation (microsoft#250588) * fix(devcontainer): bump rust feature to fix container build Rust 1.87.0 removed the RLS and rust-analysis components, which led to an error when building the 'rust' devcontainer feature. This commit bumps the feature version to 1.3.3, where those components have been removed from the build script, resolving the issue. Closes: microsoft#250420 Signed-off-by: Oleksandr Zakharov <[email protected]> * handle markdown string correctly, fix bug (microsoft#250653) * Fix for splitting search editor behavior * allow announcement to play when there's no sound for user action required from chat (microsoft#250655) fixes microsoft#250643 * force `instanceLimit` to be at least 1 (microsoft#250657) force instanceLimit to be at least 1 * Fix for pending promise of aisearch * acct for udf setting (microsoft#250663) * make setting experimental (microsoft#250665) * Initial plan for issue * Initial plan for issue * Enhance SendSequence command to support manual input and escape sequences Co-authored-by: Tyriar <[email protected]> * revert addition of `killGracefully` setting (microsoft#250668) revert addition of killGracefully setting microsoft#206607 * Implement workbench.action.terminal.sendSignal command Co-authored-by: Tyriar <[email protected]> * Remove redundant writeDataToTerminal command Co-authored-by: Tyriar <[email protected]> * Fix race condition in unregistering authentication providers (microsoft#250667) A minimal change for endgame. * commands: fix for startup command in vscode.dev/edu route (microsoft#250680) * commands: fix for startup command in vscode.dev/edu route Closes microsoft/vscode-dev#1290 properly. I didn't realize that, if given a promise, `Promise.resolve` just returns that same promise, so my attempt to hide the `cancel` method didn't work. * update comment * Fix SSE auth in MCP (microsoft#250686) Do retries on 401. * `undo requests` hover padding for consistency (microsoft#250688) padding for hover for consistency * show missingFromGallery warning only when `isEnabled && isRunning` (microsoft#250689) show missingFromGallery warning only when isEnabled && isRunning (microsoft#250433) * fix image hover langauge and some omission issues (microsoft#250692) fix hover isues * Initial plan for issue * Boost main and master branches in terminal suggest completions Co-authored-by: Tyriar <[email protected]> * Implement git branch prioritization in compareCompletionsFn - Revert changes to upstream/git.ts per feedback - Add git branch boosting logic to terminalCompletionModel.ts compareCompletionsFn - Boost main and master branches for git commands from terminal-suggest provider - Add comprehensive test suite for git branch priority sorting - Follows same pattern as existing LSP provider boost logic Co-authored-by: Tyriar <[email protected]> * chat - do not activate core agent which is not an extension (microsoft#250717) * Fix casing in setting description * Fix casing in setting description * When revealing/navigation hunks, reveal the line one above so that the deleted-view-zone and its hunk actions are fully visible (microsoft#250721) fixes microsoft#247374 * chat - tweak indicator for setup to more cohorts (microsoft#250724) * update known variables (microsoft#250723) * only show "Configure Tool Sets" when chat and tools are enabled (microsoft#250725) fyi @bpasero * polsih fileLocator.createFilesUpdatedEvent * fix mcp server icon in extensions view (microsoft#250727) * Initial plan for issue * Optimize compareCompletionsFn for better JIT performance Co-authored-by: Tyriar <[email protected]> * Fix race condition in terminal quick fix provider registration Co-authored-by: Tyriar <[email protected]> * Fix test format errors and improve main/master branch ordering Co-authored-by: Tyriar <[email protected]> * Update test files to use SendSequence instead of WriteDataToTerminal Co-authored-by: Tyriar <[email protected]> * Fix compilation errors by implementing sendSignal method in missing classes Co-authored-by: Tyriar <[email protected]> * Format terminalActions.ts * Remove unused imports * Remove special main/master ordering, use regular completion sorting Co-authored-by: Tyriar <[email protected]> * Avoid using accessor after await * Add hack note, improve condition * Move git branch boost below main score check * Tweak tests * fixes microsoft#250734 (microsoft#250735) * Move git branch boost after score comparison to avoid global prioritization Co-authored-by: Tyriar <[email protected]> * Revert "Move git branch boost after score comparison to avoid global prioritization" This reverts commit b3275ed. * ployfill `navigator` on NodeJS - but to `undefined` (microsoft#250619) * ployfill `navigator` on NodeJS - but to `undefined` This is used so that we can learn about extensions probing for `navigator` on NodeJS. With latest version this will pass and likely be surprising because navigator historically means browser, not NodeJS * chore: polyfill behind a setting * chore: fix tests * chore: update doc * chore: log err stack in development --------- Co-authored-by: deepak1556 <[email protected]> * fix microsoft#247189 (microsoft#250739) * Show signal command in command palette * hygiene, remove unused * Add signal picker when no args provided to sendSignal command Co-authored-by: Tyriar <[email protected]> * Fixes telemetry error * Remove to terminal as it's the category * Add manual signal input option to sendSignal command Co-authored-by: Tyriar <[email protected]> * Only show send signal command when no Windows * animate tree indent guides via opacity * Move accessor use to top, await ipc * instructions.md files duplicated in prompts (microsoft#250742) * Localize * updated names in endgame notebook (microsoft#250748) * chore: update @vscode/[email protected] (microsoft#250749) * chore: bump [email protected] (microsoft#250608) * chore: bump [email protected] * chore: update build * chore: update distro * Instruction files - comma separated list of glob patterns not working in applyTo property (microsoft#250754) * Instruction files - comma separated list of glob patterns not working in applyTo property * use path, not fsPath * fix test * make sure `InlineAnchorWidget` get disposed (microsoft#250759) fixes microsoft#250758 * Directly query for extension version before declaring it missing (microsoft#250763) * directly query for extension version before declaring it missing * always fire event * show missingFromGallery even when extension is disabled or not running * whitespace * Correct completion kind * Bulk query marketplace check for missingFromMarketplace (microsoft#250775) * bulk query marketplace, add telemetry * send telemetry on non-zero missingcount * more useful telemetry * telemetry for queriedIds and missingIds * no need for an extra loop * force no border on request monaco list row (microsoft#250777) * Fix cell reveal when followCellExecution enabled and notebook tab not active (microsoft#250646) * Initial plan for issue * Fix cell reveal when followCellExecution enabled and notebook tab not active - Add ensureNotebookEditorVisible function to bring notebook tab into view before revealing cells - Modify runCell function to ensure notebook editor is visible when autoReveal is enabled - Update all runCell calls to pass editorService for finding and opening notebook editor - Fixes issue where cells were not revealed when notebook tab was not currently active Co-authored-by: Yoyokrazy <[email protected]> * whitespace * rm obvious comment + revealIfOpened * the actual correct solution --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Yoyokrazy <[email protected]> Co-authored-by: Michael Lively <[email protected]> * Chat code block pill token updates (microsoft#250531) * update colors for icon labels to meet accessibility color contrast requirements * - update colors for added and removed labels to pass color contrast requirements - added the used tokens to vscode-known-variables * fixing margin-left * update editor gutter colors for added and deleted resources, removed the previously added gitDecoration tokens from known variables * update editor gutter colors for added and deleted lines in dark_modern and updated the fallback colors for editorGutterDeletedBackground * undoing changes to editorGutterAddedBackground and editorGutterDeletedBackground * add foreground colors for added and deleted lines in chat code blocks in chatColors.ts * add chat foreground colors for added and deleted lines in vscode-known-variables.json * rename chat color variables for added and removed lines in chat code block pill --------- Co-authored-by: Justin Chen <[email protected]> * hello 1.102.0 (microsoft#250791) * Implements Terminal: Run Recent Command when there are no terminals * Add comments * debt - adopt `findEditors` in more places (microsoft#250712) * fix microsoft#247849 (microsoft#250803) * debt - more powerful layer checker with TS support (microsoft#250752) * SCM - disable variable line height in the input field (microsoft#250802) * Fix extraction of tab title name (microsoft#250621) * Fix extraction of tab title name Fixes microsoft/vscode-internalbacklog#5499 * Engineering - update agent pool --------- Co-authored-by: Ladislau Szomoru <[email protected]> * fix microsoft#248686 (microsoft#250810) * replace `wait` util with `timeout` usage * remove `waitRandom` * use `mock` over `mockObject` duplicate * debt - some assorted changes (microsoft#250807) * debt - some assorted fixes * fix ci * remove duplicate dependency * Fix launch.json reference Signed-off-by: Emmanuel Ferdman <[email protected]> * chore - Use simple suite- and test-names and leave styling up to the reporter (microsoft#250811) * deprecate self-dispose object/pattern (microsoft#250815) migrate cell entry fyi @DonJayamanne re microsoft#248366 * fix microsoft#247820 (microsoft#250816) * Refactoring editor sticky scroll (microsoft#248131) * refactor: enhance documentation for StickyLineCandidateProvider methods microsoft#248082 * Removed unusued statement causing hygiene build to fail microsoft#244845 * polish --------- Co-authored-by: Aiday Marlen Kyzy <[email protected]> Co-authored-by: Aiday Marlen Kyzy <[email protected]> * Fix line comment action for makefiles (Fixes microsoft#234464) (microsoft#243283) * Fix line comment action for makefiles (Fixes microsoft#234464) Pass languageId to _analyzeLines to distinguish makefiles from the rest of the languages. Add test to _analyzeLines specifically for makefiles. * Remove hardcoded string. Apply fix at LanguageConfigurationService. Add comment rule to specify fixed column token placement. Change test scope to test line command instead of just testing the _analyzeLines method. * change added field to use bool instead of user-chosen offset * add check to remove comment detection * add check to following space removal * update branch. add config interface for new noindent option. adapt existing logic for new config format. * fix small issue with following space removal * polish --------- Co-authored-by: Aiday Marlen Kyzy <[email protected]> * Verify the range is valid before getting the lin max column (microsoft#250450) verify the range is valid before getting the lin max column * Consider line comments when determining indentation (microsoft#250591) * Add setting autoindent on paste (microsoft#250463) * add setting autoindent on paste * setting value to false * remove ignoring of indentation when indenting line comments * adding back code * reveal next file when keep/undoing last hunk (microsoft#250821) * debt - use `esbuild` for CSS minification (microsoft#250820) * avoid const-export-function-expression (microsoft#250826) microsoft#248387 * chore - cleanup decoratior util (microsoft#250827) * no more `asyncTransaction` usage in chat land (microsoft#250831) fixes microsoft#248827 * Fixes microsoft#242059 * Add setting autoIndentOnPasteWithinString (microsoft#250465) * add setting autoindent on paste * setting value to false * autoindentonpastewithinstring * move prompt file actions under vs/workbench/contrib/chat/browser/promptSyntax (microsoft#250836) * Move promptfile actions/pickers under workbench/contrib/chat/browser/promptSyntax * fix * renames * fixes microsoft/vscode-copilot#12412 (microsoft#250843) * move prompt codecs and utils to workbench/contrib/chat/common/promptSyntax (microsoft#250847) * `assertIsDefined` vs `assertDefined` (fix microsoft#248362) (microsoft#250844) * chat - core provided chat submenus in components (microsoft#250851) * Fixes microsoft/vscode-copilot#13637 * Fixes microsoft#230056. (microsoft#250856) Co-authored-by: Dipta Mahardhika <[email protected]> * SingleLineEdit -> LineReplacement * chore - remove unused `toolSelectionIsExclusive` fyi @roblourens (microsoft#250860) * Ensure test cases use argument completion kind only * Add more test cases * [email protected] Fixes microsoft#190629 * Fix hasErrors property for compound task problem matcher events (microsoft#250784) Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: meganrogge <[email protected]> Co-authored-by: meganrogge <[email protected]> * Improve debug adapter capabilities checking (microsoft#250779) * some tiny prep work for microsoft#249519 (microsoft#250863) * don't animate visibility, opacity is enough (microsoft#250866) microsoft#250746 * Improve case where active instance already exists * Revert "Merge pull request microsoft#250670 from microsoft/copilot/fix-250669" This reverts commit aa095f8, reversing changes made to 13ff454. * Add picker to sendSequence command Fixes microsoft#250669 * Initial plan for issue * Fix syntax error in quickPickPin.ts getItemIdentifier function Co-authored-by: Tyriar <[email protected]> * Add styling for label suffix in attached context attachments * Update label suffix and description opacity to revert to previous styling. * Remove any unexpected properties when persisting pinned item * Make write data and send seqeunce commands use same supprots label Part of microsoft#250669 * Set opacity to 1 for label suffix in chat attached context attachments * Move send signal/sequence into terminalContrib * Inline implementations * Refactor label suffix selector for chat attached context attachments * Move send sequence keybindings into terminalcontrib * Split send signal and sequence into own contribs * mcp: fix resource picker sometimes is empty (microsoft#250892) We didn't trigger a 'change' after the promise resolved, so if we resolve rec.templates and rec.resources synchronously (for a server with no mcp resources) then we could end before publishing everything Refs microsoft#250890 * mcp: fix resource picker sometimes is empty (microsoft#250891) We didn't trigger a 'change' after the promise resolved, so if we resolve rec.templates and rec.resources synchronously (for a server with no mcp resources) then we could end before publishing everything Refs microsoft#250890 * move platform/prompts to vs/workbench/contrib/chat/common/promptSyntax (microsoft#250889) * move platform/prompts to vs/workbench/contrib/chat/common/promptSyntax * promptSync: bring back extension check * mcp: support system message is sampling (microsoft#250900) Ref https://github.com/microsoft/vscode/issues/244162\#issuecomment-2946034316 * testing: preserve path on failed cases (microsoft#250757) Ref Dart-Code/Dart-Code#5534 * cover the constructor as well (microsoft#250675) * mcp: fix authority-less MCP resources cannot be read by VS Code (microsoft#250908) Fixes microsoft#250905 * mcp: adopt finalized completions API, support resolved args for prompts too (microsoft#250909) Refs microsoft#248418 * Add setting to skip word counting/render smoothing (microsoft#250912) * use export function x(...) instead of export const x (microsoft#250927) * debt - improve type and layer checking (microsoft#250926) * mcp: add request trace-level logging (microsoft#250898) * mcp: add request trace-level logging Refs microsoft#250537 * fix * update headers for layers * 🆙 `open@^10.1.2` (microsoft#250980) * debt - restore old layer name (microsoft#250928) * check tool specific enablement when reading tool set (microsoft#250983) fixes microsoft/vscode-copilot#18161 * chore: use node-gyp from build dir for the project (microsoft#250981) * chore: bump node-gyp on windows to 11.2.0 improves reliability of builds on windows includes nodejs/node-gyp#3113 and nodejs/node-gyp#3112 * use preinstalled node-gyp * use bundled node-gyp for subdirs too * chore: revert changes to package-lock.json * chore: rebuild package-lock.json * ci: rebuild cache --------- Co-authored-by: Aman Karmani <[email protected]> * chore - "Remove File" and "Clear Working Set" action removal. (microsoft#250991) * chore - "Remove File" and "Clear Working Set" action removal. Both are from the time out working set and since a while we have list of modified files so both actions don't make sense anymore * fix compilo * debt - ensure to remove listeners * make sure the API doesn't allow to set an empty selections array (microsoft#251010) re microsoft/vscode-copilot#18075 * api notes/todos (microsoft#251020) * removed commented out code --------- Signed-off-by: Oleksandr Zakharov <[email protected]> Signed-off-by: Emmanuel Ferdman <[email protected]> Co-authored-by: Luyu Cheng <[email protected]> Co-authored-by: Matthew Godin <[email protected]> Co-authored-by: matthew-godin <[email protected]> Co-authored-by: Daniel Imms <[email protected]> Co-authored-by: Joanna Oikawa <[email protected]> Co-authored-by: Joanna Oikawa <[email protected]> Co-authored-by: Aaron Munger <[email protected]> Co-authored-by: Connor Peet <[email protected]> Co-authored-by: Tyler James Leonhardt <[email protected]> Co-authored-by: Justin Chen <[email protected]> Co-authored-by: Benjamin Pasero <[email protected]> Co-authored-by: Johannes Rieken <[email protected]> Co-authored-by: Benjamin Christopher Simmonds <[email protected]> Co-authored-by: Sandeep Somavarapu <[email protected]> Co-authored-by: Megan Rogge <[email protected]> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Bhavya U <[email protected]> Co-authored-by: Oleksandr Zakharov <[email protected]> Co-authored-by: Osvaldo Ortega <[email protected]> Co-authored-by: Osvaldo Ortega <[email protected]> Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Josh Spicer <[email protected]> Co-authored-by: Nick Trogh <[email protected]> Co-authored-by: Martin Aeschlimann <[email protected]> Co-authored-by: deepak1556 <[email protected]> Co-authored-by: Henning Dieterichs <[email protected]> Co-authored-by: Yoyokrazy <[email protected]> Co-authored-by: Michael Lively <[email protected]> Co-authored-by: Kaitlin Brooks <[email protected]> Co-authored-by: Sublimeful <[email protected]> Co-authored-by: Ladislau Szomoru <[email protected]> Co-authored-by: Emmanuel Ferdman <[email protected]> Co-authored-by: Raffaele Garofalo <[email protected]> Co-authored-by: Aiday Marlen Kyzy <[email protected]> Co-authored-by: Aiday Marlen Kyzy <[email protected]> Co-authored-by: Enzo Nunes <[email protected]> Co-authored-by: Dipta Mahardhika <[email protected]> Co-authored-by: meganrogge <[email protected]> Co-authored-by: DrSergei <[email protected]> Co-authored-by: Kaitlin Brooks <[email protected]> Co-authored-by: Rob Lourens <[email protected]> Co-authored-by: Aman Karmani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm run lint && npm testpassesDescription of change
on some linux machines, i observed:
(side note: i'm not sure why the http fetch is not being retried, or where the "attempt 1" comes from)
unfortunately this leaves the system in a broken state, as a subsequent retries (with my own loop around npm) all fail:
this is apparently a known and documented issue. i have implemented the recommended workaround in this PR.