Skip to content

batch requests in wpt #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025
Merged

batch requests in wpt #813

merged 2 commits into from
May 22, 2025

Conversation

KhafraDev
Copy link
Member

closes #810

I have no idea how to add tests for this, but hopefully it's straightforward. This is needed for undici to use git node wpt to pull tests for its runner.

Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment explaining why we're doing this? Otherwise there's a chance it gets reverted if this code is ever refactored

@aduh95
Copy link
Contributor

aduh95 commented May 22, 2025

@KhafraDev is this still needed?

@KhafraDev
Copy link
Member Author

I haven't had to use git node wpt recently but I assume the issue is still present

Copy link

codecov bot commented May 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 80.15%. Comparing base (39f1002) to head (dfbde9d).
Report is 106 commits behind head on main.

Files with missing lines Patch % Lines
lib/wpt/index.js 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #813      +/-   ##
==========================================
- Coverage   83.02%   80.15%   -2.88%     
==========================================
  Files          37       39       +2     
  Lines        4213     4635     +422     
==========================================
+ Hits         3498     3715     +217     
- Misses        715      920     +205     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 merged commit ce893fc into nodejs:main May 22, 2025
12 of 15 checks passed
@KhafraDev KhafraDev deleted the batch-requests branch May 22, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git node wpt times out on large folders
2 participants