Skip to content

ansible: install clang38 on FreeBSD 10.x machines #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

kfarnung
Copy link

@kfarnung kfarnung commented Jun 27, 2017

FreeBSD 10.x ships by default with clang-3.4.1, which is below the minimum for Node.js builds. That version (as well as 3.4.2 and 3.5.2) crashes when attempting to build V8 6.0. Specifically install the clang38 package on those hosts.

Validation steps

  • Installed FreeBSD 10 and 11 on VMs
  • Added them to the local Ansible inventory
  • Added fake secret entries for each machine
  • Ran the jenkins/worker/create playbook against both hosts
  • Verified that clang38 is only installed on the FreeBSD 10 host
  • Verified that the custom CC/CXX variables are only applied to the FreeBSD 10 host

@kfarnung
Copy link
Author

/cc @nodejs/build

I used #650 as a template, but it seems like there was some refactoring done since. Are the playbooks under setup/ still used?

@kfarnung
Copy link
Author

Looks like the CC/CXX variables are set in the init.d template: https://github.com/nodejs/build/blob/master/ansible/roles/jenkins-worker/templates/freebsd.initd.j2#L31

@gibfahn
Copy link
Member

gibfahn commented Jun 27, 2017

Are the playbooks under setup/ still used?

We're moving away from them as quickly as possible.

jbergstroem

This comment was marked as off-topic.

@kfarnung
Copy link
Author

kfarnung commented Jun 27, 2017

@gibfahn Do you want me to attempt to update the older scripts?

@jbergstroem I took a stab at adding a config for the compilers and pushed an update. I verified on my machine that it applies correctly on both FreeBSD 10 and 11 (doesn't change the latter).

As discussed in #723, it looks like clang34 (3.4.2) and clang35 (3.5.2) both crash when compiling V8 6.0. Building with clang38 (3.8.1) was successful. Are we opposed to using clang38 for FreeBSD 10 builds?

* Install the clang38 package on freebsd10 hosts
* Updated the freebsd init template to allow configuration of the CC
  and CXX environment variables
* Added CC/CXX configuration for freebsd10 hosts
@kfarnung kfarnung changed the title ansible: install clang34 on FreeBSD 10.x machines ansible: install clang38 on FreeBSD 10.x machines Jun 27, 2017
@gibfahn
Copy link
Member

gibfahn commented Jun 28, 2017

@gibfahn Do you want me to attempt to update the older scripts?

I think we should be okay just using the newer scripts, if you've tested building/testing node after using them then that's good enough for me (idk what @jbergstroem thinks though).

@mhdawson
Copy link
Member

mhdawson commented Jun 28, 2017

I think we need to document somewhere which one should be used for which platforms. For example the Raspberry Pi ones are not complete and I burned some time using the new one before realizing that. Given that we can doc that somewhere prominently I'd agree that just have the latest be updated makes sense.

jbergstroem

This comment was marked as off-topic.

jbergstroem

This comment was marked as off-topic.

@kfarnung
Copy link
Author

It sounds like this may no longer be relevant, feel free to close if that's the case.

@kfarnung
Copy link
Author

Closing this out, feel free to resurrect if necessary.

@kfarnung kfarnung closed this Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants