Do not sign custom query string parameters #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjbarth
force-pushed
the
custom-querystring-signing
branch
from
6e7da60 to
0267178
Compare
|
Thanks for the PR. Can you add a test case for this? |
cjbarth
force-pushed
the
custom-querystring-signing
branch
4 times, most recently
from
eeca09f to
f4ef4df
Compare
cjbarth
force-pushed
the
custom-querystring-signing
branch
from
f4ef4df to
f33edd9
Compare
|
@ploer: Ok, I think the tests that I've modified should cover the changes I've made. |
|
Thanks! |
ploer
added a commit
that referenced
this pull request
Nov 3, 2015
Do not sign custom query string parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a custom query string parameter ADFS requires that only the SAMLRequest, RelayState, and SigAlg parameters be signed. Thus, this code was modified to not sign any custom query string parameters.