[BUG] Cannot read property 'Strategy' of undefined #479

ghost · 2020-10-29T21:09:45Z

After updating to 1.4.0 (also tried 1.4.1 and 1.4.2) I get the following runtime error:

/workspaces/UWER/dist/backend/index.js:93
  _passport.default.use(new _passportSaml.default.Strategy({
                                                  ^

TypeError: Cannot read property 'Strategy' of undefined
    at Object.<anonymous> (/workspaces/UWER/dist/backend/index.js:93:51)
    at Module._compile (internal/modules/cjs/loader.js:1063:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
    at Module.load (internal/modules/cjs/loader.js:928:32)
    at Function.Module._load (internal/modules/cjs/loader.js:769:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)
    at internal/main/run_main_module.js:17:47

You can view the code here.

Environment

Node.js version: 14.13.1
passport-saml version: 1.4.0, 1.4.1, 1.4.2

I don't usually develop in JS so my apologies in advance if this is my mistake.

The text was updated successfully, but these errors were encountered:

cjbarth · 2020-10-29T21:20:34Z

@gugu Do you think this might be related to some TypeScript stuff you've been working on?

markstos · 2020-10-29T21:31:34Z

@aloswald Is your codebase written in JavaScript or TypeScript? Can you show how you import/require passport-saml? This would be the line where _passportSaml is defined.

Your code appears to referencing ` a "default" property on a "_passportSaml" object, but I don't see any properties by that name in our documentation.

gugu · 2020-10-29T21:32:33Z

@aloswald can you please provide more information?

Do you use typescript? If yes, how does code look like in original version
How does import look like?

Export in v1.3 looked like this, no defaults:

ghost · 2020-10-29T21:38:26Z

No TypeScript here. Babel, yes. The app is a single code base with an express backend and React frontend.

Import (click me)

import saml from 'passport-saml';

Use (click me)

  passport.use(
    new saml.Strategy(
      {
        callbackUrl: process.env.IDPCALLBACKURL,
        entryPoint: process.env.IDPENTRYPOINT,
        issuer: process.env.IDPISSUER,
        identifierFormat: 'urn:oasis:names:tc:SAML:1.1:nameid-format:unspecified',
        privateKey: spPrivateKey
      },
      function(profile, done) {
        return done(null, {
          UWNetID: profile['urn:oid:0.9.2342.19200300.100.1.1'] || profile.nameID,
          DisplayName: profile['urn:oid:2.16.840.1.113730.3.1.241']
        });
      }
    )
  );

_default is from the Babel transformation I believe.

gugu · 2020-10-29T22:11:09Z

Can you please update import to import * as saml from 'passport-saml'?
Previously babel did this replacement automatically, but now we started to use es6 exports

I can add export default for compatibility with babel if it needed

ghost · 2020-10-29T23:07:07Z

@guru Thank you, that seemed to work. If adding export default helps not break others that use Babel it may be a good idea.

This solved my runtime issue, but I have another issue that is happening on login.

TypeError: parser.parseStringPromise is not a function
    at SAML.processValidlySignedAssertion (/www/node_modules/passport-saml/lib/passport-saml/saml.js:233:20)
    at /www/node_modules/passport-saml/lib/passport-saml/saml.js:769:29
    at _fulfilled (/www/node_modules/q/q.js:854:54)
    at /www/node_modules/q/q.js:883:30
    at Promise.promise.promiseDispatch (/www/node_modules/q/q.js:816:13)
    at /www/node_modules/q/q.js:624:44
    at runSingle (/www/node_modules/q/q.js:137:13)
    at flush (/www/node_modules/q/q.js:125:13)
    at processTicksAndRejections (internal/process/task_queues.js:75:11)

ghost · 2020-10-29T23:27:52Z

@guru Would you rather I open a new issue?

markstos · 2020-10-29T23:38:26Z

Are you sure you are using the latest release? The Q library is in the call stack, but we no longer use it.

ghost · 2020-10-30T00:00:06Z

Pretty sure. This is part of my package-lock.json:

    "passport-saml": {
      "version": "1.4.2",
      "resolved": "https://registry.npmjs.org/passport-saml/-/passport-saml-1.4.2.tgz",
      "integrity": "sha512-RJXtuiv4KWazi4zmZGVqN5pf3bV2aFbOygYzUCDEBDdeOD0yHFL4ymPOpLPXg35HvilFYTzB94JRWqwLdI2ecw==",
      "requires": {
        "debug": "^3.1.0",
        "passport-strategy": "*",
        "q": "^1.5.0",
        "xml-crypto": "^2.0.0",
        "xml-encryption": "1.2.1",
        "xml2js": "0.4.x",
        "xmlbuilder": "^11.0.0",
        "xmldom": "0.1.x"
      },

ghost · 2020-10-30T00:06:51Z

Looking at your history. The Q library was removed an hour after 1.4.2 was published.

markstos · 2020-10-30T14:53:42Z

Ah, correct. Please try 1.5.0 then, which removes the Q library.

ghost · 2020-10-30T16:02:35Z

Unfortunately, I have a new error that is happening on login. This ones a little odd, not sure if this may be a Babel issue or not.

internal/modules/cjs/loader.js:329
      throw err;
      ^

Error: Cannot find module '/www/node_modules/passport-saml/lib/passport-saml'. Please verify that the package.json has a valid "main" entry
    at tryPackage (internal/modules/cjs/loader.js:321:19)
    at Function.Module._findPath (internal/modules/cjs/loader.js:534:18)
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:27)
    at Function.Module._load (internal/modules/cjs/loader.js:743:27)
    at Module.require (internal/modules/cjs/loader.js:965:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at Object.<anonymous> (/www/dist/backend/index.js:36:36)
    at Module._compile (internal/modules/cjs/loader.js:1076:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1097:10)
    at Module.load (internal/modules/cjs/loader.js:941:32)
    at Function.Module._load (internal/modules/cjs/loader.js:782:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)
    at internal/main/run_main_module.js:17:47 {
  code: 'MODULE_NOT_FOUND',
  path: '/www/node_modules/passport-saml/package.json',
  requestPath: 'passport-saml'
}

cjbarth · 2020-10-30T16:14:39Z

Interesting... It does look like from this that we should probably be more specific with our main entry in package.json, but you're the first to report such a problem.

mjknight50 · 2020-10-30T17:00:36Z

I have the same issue...
"passport": "^0.4.1",
"passport-saml": "1.5.0",

capaj · 2020-10-31T08:39:18Z

I am also getting this on same versions as @mjknight50, just tested.

arelg · 2020-11-01T12:16:07Z

on version 1.5.0 getting:
TypeError: parser.parseStringPromise is not a function
at SAML.processValidlySignedAssertion (/app/server/node_modules/passport-saml/src/passport-saml/saml.ts:970:12)
at /app/server/node_modules/passport-saml/src/passport-saml/saml.ts:708:21
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:97:5)

gugu · 2020-11-02T10:50:44Z

Added fix for parseStringPromise. parseStringPromise was added in the patch version of xml2js and older installations keep old version

gugu · 2020-11-02T12:14:11Z

@aloswald do you install the module from npm or via github? It can happen if module is installed directly from github

mogadanez · 2020-11-02T13:51:35Z

I also have error after upgrade:

 TypeError: parser.parseStringPromise is not a function     
at SAML.processValidlySignedAssertion (/var/app/node_modules/passport-saml/lib/passport-saml/saml.js:853:16)     
at then.then.certs (/var/app/node_modules/passport-saml/lib/passport-saml/saml.js:615:29)

markstos · 2020-11-02T15:12:43Z

@mogadanez We plan to fix this in a 2.0 release later today.

thenengah · 2021-05-26T12:58:08Z

 TypeError: parser.parseStringPromise is not a function

Ah, this broke us too. We locked it to 1.4.0 until things are stable.

cjbarth · 2021-05-31T13:41:14Z

The 1.x branch isn't being actively maintained anymore. The 2.x branch has received several updates, even recently. The 3.x branch has just been released. You might try seeing if the newer branches work for you.

thenengah · 2021-05-31T13:53:33Z

@cjbarth Thanks for the tips. I'll check it out and report back.

ghost added the bug label Oct 29, 2020

markstos assigned gugu Oct 29, 2020

gugu added a commit that referenced this issue Nov 2, 2020

update version of xml2js to 0.4.23, fixes #479

5685657

markstos closed this as completed Nov 2, 2020

markstos pushed a commit that referenced this issue Nov 2, 2020

update version of xml2js to 0.4.23, fixes #479

881208b

ghost mentioned this issue Nov 3, 2020

[BUG] Cannot find module '/www/node_modules/passport-saml/lib/passport-saml'. Please verify that the package.json has a valid "main" entry #494

Closed

cjbarth mentioned this issue May 10, 2021

Changelog #587

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BUG] Cannot read property 'Strategy' of undefined #479

[BUG] Cannot read property 'Strategy' of undefined #479

ghost commented Oct 29, 2020

cjbarth commented Oct 29, 2020

markstos commented Oct 29, 2020

gugu commented Oct 29, 2020

ghost commented Oct 29, 2020

gugu commented Oct 29, 2020

ghost commented Oct 29, 2020 •

edited by ghost

Loading

ghost commented Oct 29, 2020

markstos commented Oct 29, 2020

ghost commented Oct 30, 2020

ghost commented Oct 30, 2020 •

edited by ghost

Loading

markstos commented Oct 30, 2020

ghost commented Oct 30, 2020

cjbarth commented Oct 30, 2020

mjknight50 commented Oct 30, 2020 •

edited

Loading

capaj commented Oct 31, 2020

arelg commented Nov 1, 2020

gugu commented Nov 2, 2020

gugu commented Nov 2, 2020

mogadanez commented Nov 2, 2020

markstos commented Nov 2, 2020

thenengah commented May 26, 2021

cjbarth commented May 31, 2021

thenengah commented May 31, 2021

[BUG] Cannot read property 'Strategy' of undefined #479

[BUG] Cannot read property 'Strategy' of undefined #479

Comments

ghost commented Oct 29, 2020

cjbarth commented Oct 29, 2020

markstos commented Oct 29, 2020

gugu commented Oct 29, 2020

ghost commented Oct 29, 2020

gugu commented Oct 29, 2020

ghost commented Oct 29, 2020 • edited by ghost Loading

ghost commented Oct 29, 2020

markstos commented Oct 29, 2020

ghost commented Oct 30, 2020

ghost commented Oct 30, 2020 • edited by ghost Loading

markstos commented Oct 30, 2020

ghost commented Oct 30, 2020

cjbarth commented Oct 30, 2020

mjknight50 commented Oct 30, 2020 • edited Loading

capaj commented Oct 31, 2020

arelg commented Nov 1, 2020

gugu commented Nov 2, 2020

gugu commented Nov 2, 2020

mogadanez commented Nov 2, 2020

markstos commented Nov 2, 2020

thenengah commented May 26, 2021

cjbarth commented May 31, 2021

thenengah commented May 31, 2021

ghost commented Oct 29, 2020 •

edited by ghost

Loading

ghost commented Oct 30, 2020 •

edited by ghost

Loading

mjknight50 commented Oct 30, 2020 •

edited

Loading