Skip to content

README file should indicate signature checking is critical (not just a good idea) #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexstuart opened this issue Apr 7, 2017 · 3 comments
Labels
documentation Request for or contribution to documentation good first issue pr-welcome

Comments

@alexstuart
Copy link

README.md says "It is a good idea to validate the incoming SAML Responses." It's not just a good idea, it's a critical part of the security of the system. Section 5 of SAML core spec notes that "A SAML protocol request or response message signed by the message originator supports message integrity, authentication of message origin to a destination, and, if the signature is based on the originator's public-private key pair, non-repudiation of origin." By not verifying signatures, you lose a lot of that protection. The README file should indicate that.

@markstos
Copy link
Contributor

Pull request welcome.

@cjbarth cjbarth added documentation Request for or contribution to documentation and removed 1.0 labels Mar 31, 2021
@srd90
Copy link

srd90 commented Feb 3, 2022

Pull request #548 might have resolved this issue also (from security point of view) even though documentation still says that "It is good idea..." at chapter README.md#security-and-signatures (link points to version 3.2.1).

#548 was released at 3.0.0 (release notes) and it made IdP certificate a mandatory configuration option

@markstos
Copy link
Contributor

markstos commented Feb 3, 2022

Closing because making the cert mandatory is even better than documenting that it's a good idea. A patch to further improve the docs is still welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Request for or contribution to documentation good first issue pr-welcome
Projects
None yet
Development

No branches or pull requests

4 participants