-
Notifications
You must be signed in to change notification settings - Fork 68
Add assertion attributes to child object on profile (passport-saml#543) #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add assertion attributes to child object on profile (passport-saml#543) #5
Conversation
This attributes are also mounted to profile directly in a non conflicting way.
This failed build on 16.x is also failing on master. Will check and raise a PR to fix |
@cjbarth @zoellner The test in node v16 is failing due to a bug in npm which causes npm to break after running
|
.github/workflows/workflow.yml
Outdated
@@ -24,7 +24,11 @@ jobs: | |||
- run: npm ci | |||
- run: npm test | |||
- run: npm ci | |||
- run: npm --depth 9999 update | |||
- run: npm update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this then working in passport-saml
if it isn't working here in node-saml
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried running these commands in the same sequence with passport-saml's package.json on this repo, but still the command was failing for this repo and not for passport-saml.
@kriss1897 Do you have a link to the bug in |
No, I didn't see any open npm tickets regarding the same. I found some old ones and some stackoverflow threads. Try this: https://www.google.com/search?q=cannot+find+module+npmlog+after+npm+update |
It seems that this has been fixed. Could we revert the change and try again? |
…rcome npm-cli bug" This reverts commit 9b1a411.
This attributes are also mounted to profile directly in a non conflicting way.
Duplicate PR of: node-saml/passport-saml#593