fix: airbnb + prettier lint; and update tests #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charlike Mike Reagent <[email protected]>
|
This pull request introduces 1 alert when merging cbb1f60 into fd09519 - view on LGTM.com new alerts:
|
|
.eslintcache can be inside gitignore |
|
Ah yea. |
GrosSacASac
previously approved these changes
Jan 28, 2020
Signed-off-by: Charlike Mike Reagent <[email protected]>
Signed-off-by: Charlike Mike Reagent <[email protected]>
|
This pull request introduces 1 alert when merging 37711f7 into a5db8d9 - view on LGTM.com new alerts:
|
Signed-off-by: Charlike Mike Reagent <[email protected]>
|
This pull request introduces 1 alert when merging 37e26aa into a5db8d9 - view on LGTM.com new alerts:
|
Signed-off-by: Charlike Mike Reagent <[email protected]>
|
This pull request introduces 1 alert when merging e773e60 into a5db8d9 - view on LGTM.com new alerts:
|
Signed-off-by: Charlike Mike Reagent <[email protected]>
Signed-off-by: Charlike Mike Reagent <[email protected]>
Signed-off-by: Charlike Mike Reagent <[email protected]>
|
This pull request introduces 1 alert when merging db87d8d into a5db8d9 - view on LGTM.com new alerts:
|
Signed-off-by: Charlike Mike Reagent <[email protected]>
Signed-off-by: Charlike Mike Reagent <[email protected]>
tunnckoCore
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ton of stuff. Part of #415.
Tests are failing, but I have idea why. Probably because the changes to support "multiples" / array "files" and "fields" things in the other PRs.
Also, there is a problem here https://github.com/node-formidable/node-formidable/blob/lin-format-misc/src/multipart_parser.js#L108-L113
With that there is two
callback. Left it asvar callback. But I'm not entirely sure which callback (thisvar callbackor the method'scallbackparam) should be called later.