Force form.multiples to always return array

[gabeio]

When uploading one file to a formidable with form.multiples = true then the req.files.[name] would just be the file instead should be array of files as suggested by the documentation.

[gabeio]

This would close #292.

[charmander]

!Array.isArray(files[name]) is implied by !files[name]; this would just be files[name] = [file];. (Still, given the Array.isArray check above, it looks as if the intent was for single files not to be arrays.)

[xarguments]

Contains logical duplication that can be simplified:

It all can be simplified down to this:

if (this.multiples) {
  if (!files[name]) {
    files[name] = [];
  }
  files[name].push(file);
}

Note that it will do the same (will return always an array). But has no complicated/odd else blocks.

Anyway it should also be documented as well, and perhaps may need a version change (as its not backward compatible).

[tunnckoCore]

You right requested change, but it was around 4 years? Isn't better to just make another PR, or actually just update this one directly.

[kornelski]

Requirements for this feature:

• 100% backwards compatible. Leave the existing field exactly as it is. This package has been stable for a very long time. Let's avoid splitting userbase by bumping semver-major. New feature can be added to a new field.

• The user shouldn't need to sniff types to use it properly. Specifically, it can't be sometimes a file and sometimes an array. The new field that supports multiple files should always be an array with 1 or more items. This way it won't be possible to break applications that hardcode read of .name by sending two files under name.

[charmander]

Specifically, it can't be sometimes a file and sometimes an array.

That’s how it already works.

[xarguments]

1. Agree, we shouldn't break backward compatibility for it.
2. From the other side, it's like (bad) inconsistency - the same code can return object and array,
   and dev should check it before handling it... And there are lots of open issues which are related to it, so devs surely want it (and we can close bunch of those "issues" if we provide it)

So, we can make it configurable, e.g. provide a setting which makes it always return array. Feature request?

[tunnckoCore]

Ooops, I just merged #380, should it be supported only behind the multiples option? There wasn't a check for this.multiples.

/cc @xarguments @kornelski @charmander @GrosSacASac

[tunnckoCore]

Okay, my bad, that's for files and #380 is for fields, haha.

[GrosSacASac]

I propose: Make the multiple always return arrays for both fields and files.

It does not need a new flag and is backwards compatible as application using multiples: true should already have an if else for arrays or objects.

I can make a new PR.

[GrosSacASac]

Continue disscussion #292