Skip to content

tests: Mark the tests that don't need to downoad test files with the … #4669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

LocutusOfBorg
Copy link
Contributor

This way in Debian and Ubuntu we can easily skip them when no internet is available

@coveralls
Copy link

coveralls commented Feb 27, 2025

Coverage Status

coverage: 99.186%. remained the same
when pulling eedb7a8 on LocutusOfBorg:offline-tests
into 8215dba on nlohmann:develop.

@gregmarr
Copy link
Contributor

Is it better to mark the ones that don't need to download things, or the ones that do?

@nlohmann
Copy link
Owner

nlohmann commented Apr 4, 2025

From the README:

Note that during the ctest stage, several JSON test files are downloaded from an external repository. If policies forbid downloading artifacts during testing, you can download the files yourself and pass the directory with the test files via -DJSON_TestDataDirectory=path to CMake. Then, no Internet connectivity is required. See issue #2189 for more information.

Would using JSON_TestDataDirectory be an option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants