Skip to content

prysm: 5.0.3 -> 5.3.0 #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

JulianGodd
Copy link
Contributor

Updated prysm to 5.3.0 and the version of go to 1.23 to match the repo

This fixes my issue with the overlay.

Copy link
Collaborator

@bbjubjub2494 bbjubjub2494 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! For this to build in the context of ethereum.nix, there need to be a couple of extra changes to make sure the go version is up-to-date. You can add them in your PR if you like

diff --git a/flake.lock b/flake.lock
index 324d36f..b1392fc 100644
--- a/flake.lock
+++ b/flake.lock
@@ -195,11 +195,11 @@
     },
     "nixpkgs-unstable": {
       "locked": {
-        "lastModified": 1736241350,
-        "narHash": "sha256-CHd7yhaDigUuJyDeX0SADbTM9FXfiWaeNyY34FL1wQU=",
+        "lastModified": 1740019556,
+        "narHash": "sha256-vn285HxnnlHLWnv59Og7muqECNMS33mWLM14soFIv2g=",
         "owner": "nixos",
         "repo": "nixpkgs",
-        "rev": "8c9fd3e564728e90829ee7dbac6edc972971cd0f",
+        "rev": "dad564433178067be1fbdfcce23b546254b6d641",
         "type": "github"
       },
       "original": {
diff --git a/pkgs/default.nix b/pkgs/default.nix
index 46fca4c..7a7da14 100644
--- a/pkgs/default.nix
+++ b/pkgs/default.nix
@@ -58,7 +58,7 @@
       mev-rs = callPackage ./mev-rs {};
       nethermind = callPackageUnstable ./nethermind {};
       nimbus = callPackageUnstable ./nimbus {};
-      prysm = callPackage ./prysm {inherit bls blst;};
+      prysm = callPackageUnstable ./prysm {inherit bls blst;};
       reth = callPackageUnstable ./reth {};
       rocketpool = callPackage ./rocketpool {};
       rocketpoold = callPackage ./rocketpoold {inherit bls blst;};

@JulianGodd
Copy link
Contributor Author

Made the suggested changes. Thanks for the fixes, I'm a bit new to this.

Is the best way to to this myself in the future with nix flake update or is there more precise way of doing it?

@bbjubjub2494
Copy link
Collaborator

Made the suggested changes. Thanks for the fixes, I'm a bit new to this.

Is the best way to to this myself in the future with nix flake update or is there more precise way of doing it?

Usually what I do is nix flake update --commit-lock-file but there doesn't seem to be a hard rule.

The PR fails to build now because the update of nixpkgs-unstable broke one of the formatters. If you do nix fmt you will see the error. It seems like there's a simple fix though

@bbjubjub2494
Copy link
Collaborator

I tried my own PR to see if it would build #579.

We seem to be running into an issue with blutgang I've seen before #574 (review)

There's an error message which explains it:

evaluation warning: rustPlatform.fetchCargoTarball is deprecated in favor of rustPlatform.fetchCargoVendor.                                                    
                    If you are using buildRustPackage, try setting useFetchCargoVendor = true and regenerating cargoHash.                                      
                    See the 25.05 release notes for more information.   

Fixed in facc2b3

@JulianGodd
Copy link
Contributor Author

Awesome! Let me know there's anything I can contribute.
Thanks again

@bbjubjub2494
Copy link
Collaborator

@JulianGodd would you mind closing since #579 has gone through? Thanks again for getting this started btw

@JulianGodd
Copy link
Contributor Author

Happily! Thanks for doing this

@JulianGodd JulianGodd closed this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use ethereum-nix with nixpkgs 24.11
2 participants