Skip to content

fix(externals): avoid overriding packages with version conflict #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 19, 2022

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Sep 19, 2022

πŸ”— Linked issue

resolves #503
resolves #456
resolves #161

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Changes for externals handling (node targets):

  • Resolve symlinks of traced files to properly dedup for pnpm
  • Also show warning for major version changes with leading zero (0.1.0 => 0.2.0 and 0.0.1 => 0.0.2)
  • Improve warning formatting and show it once
  • Fix: ignore entire directory of older version packages
  • Revert back windows fix for (docs: fix typo in storage docsΒ #424) as we are now for sure writing files once.
  • resolve nodeModulesDirs relative to rootDir
  • Add tests

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 marked this pull request as ready for review September 19, 2022 13:51
@pi0 pi0 changed the title fix: avoid overriding packages with version conflict fix(externals): avoid overriding packages with version conflict Sep 19, 2022
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #515 (691e7fc) into main (9f3f017) will increase coverage by 0.42%.
The diff coverage is 97.29%.

@@            Coverage Diff             @@
##             main     #515      +/-   ##
==========================================
+ Coverage   63.54%   63.96%   +0.42%     
==========================================
  Files          55       55              
  Lines        3626     3644      +18     
  Branches      395      400       +5     
==========================================
+ Hits         2304     2331      +27     
+ Misses       1308     1299       -9     
  Partials       14       14              
Impacted Files Coverage Ξ”
src/rollup/plugins/externals.ts 88.34% <97.22%> (+4.07%) ⬆️
src/options.ts 48.88% <100.00%> (+0.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant