Skip to content

fix: add resolved side-effect for node-fetch-native #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #434

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

moduleSideEffects was getting called both with full path to polyfill (including dist) and without. Without both paths in side effect list, we don't end up including side effects in the prerenderer build

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Aug 23, 2022
@danielroe danielroe requested a review from pi0 August 23, 2022 15:24
@danielroe danielroe self-assigned this Aug 23, 2022
@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #435 (ce1da9c) into main (0f241bc) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
+ Coverage   56.23%   56.28%   +0.05%     
==========================================
  Files          54       54              
  Lines        3466     3470       +4     
  Branches      366      366              
==========================================
+ Hits         1949     1953       +4     
  Misses       1164     1164              
  Partials      353      353              
Impacted Files Coverage Ξ”
src/options.ts 87.15% <100.00%> (+0.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 merged commit 0aa77a9 into main Aug 23, 2022
@pi0 pi0 deleted the fix/side-effects branch August 23, 2022 15:32
WinterYukky pushed a commit to WinterYukky/nitro that referenced this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node polyfills appear to be broken for prerenderer
2 participants