-
Notifications
You must be signed in to change notification settings - Fork 27
Added opengraphs
option for open graph tags on docs
#305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ad8b74a
to
fc76966
Compare
fc76966
to
197fc76
Compare
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
==========================================
- Coverage 76.41% 76.19% -0.22%
==========================================
Files 34 34
Lines 2883 2899 +16
Branches 192 194 +2
==========================================
+ Hits 2203 2209 +6
- Misses 488 496 +8
- Partials 192 194 +2
Continue to review full report at Codecov.
|
197fc76
to
08d4eb7
Compare
08d4eb7
to
a0b5e5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build fails:
app/nirum-docs.hs:32:39: warning: [-Wmissing-fields]
• Fields of ‘Docs’ not initialised: docsOpenGraph
• In the ‘target’ field of a record
In the expression:
Metadata
{version = Nirum.Version.version,
description = Just
"IDL compiler and RPC/distributed object framework for microservices",
license = Just "GPL-3",
keywords = ["IDL", "microservices", "SOA", ....],
authors = [Author "Nirum team" Nothing Nothing],
Nirum.Package.Metadata.target = Docs
{docsTitle = "Nirum", docsStyle = style,
docsHeader = "", docsFooter = footer}}
In an equation for ‘packageMetadata’:
packageMetadata
= Metadata
{version = Nirum.Version.version,
description = Just
"IDL compiler and RPC/distributed object framework for microservices",
license = Just "GPL-3", keywords = ["IDL", "microservices", ....],
authors = [Author "Nirum team" Nothing Nothing],
Nirum.Package.Metadata.target = Docs
{docsTitle = "Nirum", docsStyle = style,
docsHeader = "", docsFooter = footer}}
|
32 | , Nirum.Package.Metadata.target = Docs
| ^^^^...
nirum-docs.hs: app/nirum-docs.hs:(32,39)-(37,9): Missing field in record construction docsOpenGraph
CHANGES.md
Outdated
[#300]: https://github.com/nirum-lang/nirum/pull/300 | ||
[CommonMark]: http://commonmark.org/ | ||
[table syntax extension]: https://github.github.com/gfm/#tables-extension- | ||
[special attributes extension]: https://michelf.ca/projects/php-markdown/extra/#spe-attr | ||
[OpenGraph]: http://ogp.me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you append a trailing slash to the url?
CHANGES.md
Outdated
@@ -24,6 +24,7 @@ To be released. | |||
to customize the look and feel of the result pages. | |||
- Fixed an incorrect processing of [CommonMark] thight list items: it had | |||
crashed when a thight list item contains blocks other than paragraphs. | |||
- Added `opengraphs` option for [OpenGraph] objects on docs. [[#283] by GyuYong Jung] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs about this new option should be added to docs/target/docs.md file.
a0b5e5f
to
f6ab14c
Compare
f6ab14c
to
35dca72
Compare
Added `opengraphs` option for open graph tags on docs
Usage:
Closes: #283