Skip to content

Test trailers bug when there are data frames in queue #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tony612
Copy link
Contributor

@tony612 tony612 commented Dec 23, 2019

Test case for ninenines/cowlib#92

The failed test case can be seen:


Testing ninenines.cowboy-prs.req_SUITE: Starting test, 680 test cases
--
  |  
  | =ERROR REPORT==== 23-Dec-2019::13:13:14 ===
  | Ranch listener h2 had connection process started with cowboy_tls:start_link/4 at <0.8236.0> exit with reason: {{case_clause,{trailers,[{<<"grpc-status">>,<<"0">>}]}},[{cow_http2_machine,queue_data,4,[{file,"src/cow_http2_machine.erl"},{line,1339}]},{cow_http2_machine,send_or_queue_data,4,[{file,"src/cow_http2_machine.erl"},{line,1199}]},{cowboy_http2,maybe_send_data,4,[{file,"src/cowboy_http2.erl"},{line,770}]},{cowboy_http2,commands,3,[{file,"src/cowboy_http2.erl"},{line,634}]},{cowboy_http2,loop,2,[{file,"src/cowboy_http2.erl"},{line,247}]},{proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,247}]}]}
  |  
  | - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
  | req_SUITE:do_trailers failed on line 1097
  | Reason: {badmatch,{error,{stream_error,closed}}}
  | - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
  |  
  | Testing ninenines.cowboy-prs.req_SUITE: *** FAILED test case 252 of 680 ***
  |  
  | =ERROR REPORT==== 23-Dec-2019::13:13:26 ===
  | Ranch listener h2c had connection process started with cowboy_clear:start_link/4 at <0.9485.0> exit with reason: {{case_clause,{trailers,[{<<"grpc-status">>,<<"0">>}]}},[{cow_http2_machine,queue_data,4,[{file,"src/cow_http2_machine.erl"},{line,1339}]},{cow_http2_machine,send_or_queue_data,4,[{file,"src/cow_http2_machine.erl"},{line,1199}]},{cowboy_http2,maybe_send_data,4,[{file,"src/cowboy_http2.erl"},{line,770}]},{cowboy_http2,commands,3,[{file,"src/cowboy_http2.erl"},{line,634}]},{cowboy_http2,loop,2,[{file,"src/cowboy_http2.erl"},{line,247}]},{cowboy_http,parse,2,[{file,"src/cowboy_http.erl"},{line,311}]},{proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,247}]}]}
  |  
  | - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
  | req_SUITE:do_trailers failed on line 1097
  | Reason: {badmatch,{error,{stream_error,closed}}}
  | - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
  |  
  | Testing ninenines.cowboy-prs.req_SUITE: *** FAILED test case 337 of 680 ***
  | Testing ninenines.cowboy-prs.req_SUITE: TEST COMPLETE, 678 ok, 2 failed of 680 test cases


@essen
Copy link
Member

essen commented Dec 31, 2019

Merged via the other PR. Thanks!

@essen essen closed this Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants